Tom Lane ad3e61b280 Fix incorrect printing of queries with duplicated join names. ...

Given a query in which multiple JOIN nodes used the same alias
(which'd necessarily be in different sub-SELECTs), ruleutils.c
would assign the JOIN nodes distinct aliases for clarity ...
but then it forgot to print the modified aliases when dumping
the JOIN nodes themselves.  This results in a dump/reload hazard
for views, because the emitted query is flat-out incorrect:
Vars will be printed with table names that have no referent.

This has been wrong for a long time, so back-patch to all supported
branches.

Philip Dubé

Discussion: https://postgr.es/m/CY4PR2101MB080246F2955FF58A6ED1FEAC98140@CY4PR2101MB0802.namprd21.prod.outlook.com

2019-06-12 19:42:39 -04:00

..

adt

Fix incorrect printing of queries with duplicated join names.

2019-06-12 19:42:39 -04:00

cache

Don't access catalogs to validate GUCs when not connected to a DB.

2019-06-10 23:36:55 -07:00

error

Disallow setting client_min_messages higher than ERROR.

2018-11-08 17:33:26 -05:00

fmgr

Add a utility function to extract variadic function arguments

2017-10-25 07:19:59 -04:00

hash

Remove broken and useless entry-count printing in HASH_DEBUG code.

2017-08-02 12:16:57 -04:00

init

Consistently test for in-use shared memory.

2019-04-12 22:39:52 -07:00

mb

Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

2019-05-12 10:33:36 -07:00

misc

postgresql.conf.sample: add proper defaults for include actions

2019-04-17 18:12:10 -04:00

mmgr

Handle elog(FATAL) during ROLLBACK more robustly.

2017-08-14 15:43:20 -04:00

resowner

pgindent run for 9.6

2016-06-09 18:02:36 -04:00

sort

Fix actual and potential double-frees around tuplesort usage.

2018-03-28 13:26:43 -04:00

time

Fix pruning of locked and updated tuples.

2017-12-14 18:20:48 -08:00

.gitignore

…

errcodes.txt

Add the "snapshot too old" feature

2016-04-08 14:36:30 -05:00

Gen_dummy_probes.pl

Finish pgindent run for 9.6: Perl files.

2016-06-12 04:19:56 -04:00

Gen_dummy_probes.sed

Update copyright for 2016

2016-01-02 13:33:40 -05:00

Gen_fmgrtab.pl

Update copyright for 2016

2016-01-02 13:33:40 -05:00

generate-errcodes.pl

Update copyright for 2016

2016-01-02 13:33:40 -05:00

Makefile

Fix make rules that generate multiple output files.

2018-03-23 13:45:38 -04:00

probes.d

Update copyright for 2016

2016-01-02 13:33:40 -05:00