mirror of
				https://github.com/postgres/postgres.git
				synced 2025-10-31 10:30:33 +03:00 
			
		
		
		
	As shaped, two DROP ROLE queries included in "user_activity" were
showing in the reports for "wal".  The intention is to keep each test
isolated and independent, so this is incorrect.  This commit adds some
calls to pg_stat_statements_reset() to clean up the statistics once each
test finishes, so as there are no risks of overlap in the reports for
individial scenarios.
The addition in "user_activity" fixes the output of "wal".  The new
resets done in "level_tracking" and "utility" are added for consistency
with the rest, though they do not affect the stats generated in the
other tests.
Oversight in d0028e3.
Reported-by: Andrei Zubkov
Discussion: https://postgr.es/m/7beb722dd016bf54f1c78bfd6d44a684e28da624.camel@moonset.ru
		
	
		
			
				
	
	
		
			31 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			31 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
| --
 | |
| -- Validate WAL generation metrics
 | |
| --
 | |
| SET pg_stat_statements.track_utility = FALSE;
 | |
| CREATE TABLE pgss_wal_tab (a int, b char(20));
 | |
| INSERT INTO pgss_wal_tab VALUES(generate_series(1, 10), 'aaa');
 | |
| UPDATE pgss_wal_tab SET b = 'bbb' WHERE a > 7;
 | |
| DELETE FROM pgss_wal_tab WHERE a > 9;
 | |
| DROP TABLE pgss_wal_tab;
 | |
| -- Check WAL is generated for the above statements
 | |
| SELECT query, calls, rows,
 | |
| wal_bytes > 0 as wal_bytes_generated,
 | |
| wal_records > 0 as wal_records_generated,
 | |
| wal_records >= rows as wal_records_ge_rows
 | |
| FROM pg_stat_statements ORDER BY query COLLATE "C";
 | |
|                             query                             | calls | rows | wal_bytes_generated | wal_records_generated | wal_records_ge_rows 
 | |
| --------------------------------------------------------------+-------+------+---------------------+-----------------------+---------------------
 | |
|  DELETE FROM pgss_wal_tab WHERE a > $1                        |     1 |    1 | t                   | t                     | t
 | |
|  INSERT INTO pgss_wal_tab VALUES(generate_series($1, $2), $3) |     1 |   10 | t                   | t                     | t
 | |
|  SELECT pg_stat_statements_reset()                            |     1 |    1 | f                   | f                     | f
 | |
|  SET pg_stat_statements.track_utility = FALSE                 |     1 |    0 | f                   | f                     | t
 | |
|  UPDATE pgss_wal_tab SET b = $1 WHERE a > $2                  |     1 |    3 | t                   | t                     | t
 | |
| (5 rows)
 | |
| 
 | |
| SELECT pg_stat_statements_reset();
 | |
|  pg_stat_statements_reset 
 | |
| --------------------------
 | |
|  
 | |
| (1 row)
 | |
| 
 |