Michael Paquier cd6b2ae3e7 Fix waits of REINDEX CONCURRENTLY for indexes with predicates or expressions ...

As introduced by f9900df5f9, a REINDEX CONCURRENTLY job done for an
index with predicates or expressions would set PROC_IN_SAFE_IC in its
MyProc->statusFlags, causing it to be ignored by other concurrent
operations.

Such concurrent index rebuilds should never be ignored, as a predicate
or an expression could call a user-defined function that accesses a
different table than the table where the index is rebuilt.

A test that uses injection points is added, backpatched down to 17.
Michail has proposed a different test, but I have added something
simpler with more coverage.

Oversight in f9900df5f9.

Author: Michail Nikolaev
Discussion: https://postgr.es/m/CANtu0oj9A3kZVduFTG0vrmGnKB+DCHgEpzOp0qAyOgmks84j0w@mail.gmail.com
Backpatch-through: 14

2024-09-09 13:49:59 +09:00

..

aggregatecmds.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

alter.c

Repair ALTER EXTENSION ... SET SCHEMA.

2024-05-09 12:19:52 -04:00

amcmds.c

Fix typos and duplicate words

2024-04-18 21:28:07 +02:00

analyze.c

Don't lose partitioned table reltuples=0 after relhassubclass=f.

2024-07-13 08:09:36 -07:00

async.c

Use more consistently int64 for page numbers in SLRU-related code

2024-07-23 17:59:20 +09:00

cluster.c

Avoid repeating loads of frozen ID values.

2024-04-29 10:25:33 -07:00

collationcmds.c

Address more review comments on commit 2d819a08a1.

2024-03-18 11:58:13 -07:00

comment.c

Update copyright for 2024

2024-01-03 20:49:05 -05:00

constraint.c

Add missing index_insert_cleanup calls

2024-04-19 16:08:34 +02:00

conversioncmds.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

copy.c

Refactor error messages to reduce duplication

2024-08-08 15:17:11 -04:00

copyfrom.c

Refactor error messages to reduce duplication

2024-08-08 15:17:11 -04:00

copyfromparse.c

Message style improvements

2024-08-29 14:33:18 +02:00

copyto.c

Refactor error messages to reduce duplication

2024-08-08 15:17:11 -04:00

createas.c

When creating materialized views, use REFRESH to load data.

2024-07-16 15:41:22 -07:00

dbcommands.c

Explain dropdb can't use syscache because of TOAST

2024-08-19 13:43:27 +02:00

define.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

discard.c

Update copyright for 2024

2024-01-03 20:49:05 -05:00

dropcmds.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

event_trigger.c

Fix typos with function name in event_trigger.c

2024-04-17 14:56:31 +09:00

explain.c

Use PqMsg_* macros in more places.

2024-07-17 10:51:00 -05:00

extension.c

Repair ALTER EXTENSION ... SET SCHEMA.

2024-05-09 12:19:52 -04:00

foreigncmds.c

Update copyright for 2024

2024-01-03 20:49:05 -05:00

functioncmds.c

Disallow creating binary-coercible casts involving range types.

2024-08-21 12:00:03 -04:00

indexcmds.c

Fix waits of REINDEX CONCURRENTLY for indexes with predicates or expressions

2024-09-09 13:49:59 +09:00

lockcmds.c

Reintroduce MAINTAIN privilege and pg_maintain predefined role.

2024-03-13 14:49:26 -05:00

Makefile

Revert: Implement pg_wal_replay_wait() stored procedure

2024-04-11 17:28:15 +03:00

matview.c

When creating materialized views, use REFRESH to load data.

2024-07-16 15:41:22 -07:00

meson.build

Revert: Implement pg_wal_replay_wait() stored procedure

2024-04-11 17:28:15 +03:00

opclasscmds.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

operatorcmds.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

policy.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

portalcmds.c

Update copyright for 2024

2024-01-03 20:49:05 -05:00

prepare.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

proclang.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

publicationcmds.c

Revise GUC names quoting in messages again

2024-05-17 11:44:26 +02:00

schemacmds.c

Update copyright for 2024

2024-01-03 20:49:05 -05:00

seclabel.c

Update copyright for 2024

2024-01-03 20:49:05 -05:00

sequence.c

Lock owned sequences during ALTER TABLE SET { LOGGED | UNLOGGED }.

2024-06-27 19:21:05 -07:00

statscmds.c

Initialize variables to placate compiler.

2024-03-17 20:16:15 -05:00

subscriptioncmds.c

Message style improvements

2024-08-29 14:33:18 +02:00

tablecmds.c

Message style improvements

2024-08-29 14:33:18 +02:00

tablespace.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

trigger.c

Don't throw an error if a queued AFTER trigger no longer exists.

2024-06-20 14:21:36 -04:00

tsearchcmds.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

typecmds.c

Revert temporal primary keys and foreign keys

2024-05-16 08:17:46 +02:00

user.c

Remove unused #include's from backend .c files

2024-03-04 12:02:20 +01:00

vacuum.c

Revise GUC names quoting in messages again

2024-05-17 11:44:26 +02:00

vacuumparallel.c

Fix typos and duplicate words

2024-04-18 21:28:07 +02:00

variable.c

Revert "Allow parallel workers to cope with a newly-created session user ID."

2024-07-31 20:54:31 -04:00

view.c

Separate equalRowTypes() from equalTupleDescs()

2024-03-17 05:58:04 +01:00