1
0
mirror of https://github.com/postgres/postgres.git synced 2025-04-22 23:02:54 +03:00
postgres/contrib/seg/segparse.y
Peter Eisentraut 1f0de66ea2 seg: pure parser and reentrant scanner
Use the flex %option reentrant and the bison option %pure-parser to
make the generated scanner and parser pure, reentrant, and
thread-safe.

Make the generated scanner use palloc() etc. instead of malloc() etc.
Previously, we only used palloc() for the buffer, but flex would still
use malloc() for its internal structures.  As a result, there could be
some small memory leaks in case of uncaught errors.  (We do catch
normal syntax errors as soft errors.)  Now, all the memory is under
palloc() control, so there are no more such issues.

Simplify flex scan buffer management: Instead of constructing the
buffer from pieces and then using yy_scan_buffer(), we can just use
yy_scan_string(), which does the same thing internally.

The previous code was necessary because we allocated the buffer with
palloc() and the rest of the state was handled by malloc().  But this
is no longer the case; everything is under palloc() now.

(We could even get rid of the yylex_destroy() call and just let the
memory context cleanup handle everything.  But for now, we preserve
the existing behavior.)

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Andreas Karlsson <andreas@proxel.se>
Discussion: https://www.postgresql.org/message-id/flat/eb6faeac-2a8a-4b69-9189-c33c520e5b7b@eisentraut.org
2024-12-18 08:47:53 +01:00

184 lines
3.5 KiB
Plaintext

%{
/* contrib/seg/segparse.y */
#include "postgres.h"
#include <float.h>
#include <math.h>
#include "fmgr.h"
#include "nodes/miscnodes.h"
#include "utils/builtins.h"
#include "utils/float.h"
#include "segdata.h"
#include "segparse.h"
/*
* Bison doesn't allocate anything that needs to live across parser calls,
* so we can easily have it use palloc instead of malloc. This prevents
* memory leaks if we error out during parsing.
*/
#define YYMALLOC palloc
#define YYFREE pfree
static bool seg_atof(char *value, float *result, struct Node *escontext);
static int sig_digits(const char *value);
%}
/* BISON Declarations */
%parse-param {SEG *result}
%parse-param {struct Node *escontext}
%parse-param {yyscan_t yyscanner}
%lex-param {yyscan_t yyscanner}
%pure-parser
%expect 0
%name-prefix="seg_yy"
%union
{
struct BND
{
float val;
char ext;
char sigd;
} bnd;
char *text;
}
%token <text> SEGFLOAT
%token <text> RANGE
%token <text> PLUMIN
%token <text> EXTENSION
%type <bnd> boundary
%type <bnd> deviation
%start range
/* Grammar follows */
%%
range: boundary PLUMIN deviation
{
char strbuf[25];
result->lower = $1.val - $3.val;
result->upper = $1.val + $3.val;
snprintf(strbuf, sizeof(strbuf), "%g", result->lower);
result->l_sigd = Max(sig_digits(strbuf), Max($1.sigd, $3.sigd));
snprintf(strbuf, sizeof(strbuf), "%g", result->upper);
result->u_sigd = Max(sig_digits(strbuf), Max($1.sigd, $3.sigd));
result->l_ext = '\0';
result->u_ext = '\0';
(void) yynerrs; /* suppress compiler warning */
}
| boundary RANGE boundary
{
result->lower = $1.val;
result->upper = $3.val;
if ( result->lower > result->upper ) {
errsave(escontext,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("swapped boundaries: %g is greater than %g",
result->lower, result->upper)));
YYERROR;
}
result->l_sigd = $1.sigd;
result->u_sigd = $3.sigd;
result->l_ext = ( $1.ext ? $1.ext : '\0' );
result->u_ext = ( $3.ext ? $3.ext : '\0' );
}
| boundary RANGE
{
result->lower = $1.val;
result->upper = HUGE_VAL;
result->l_sigd = $1.sigd;
result->u_sigd = 0;
result->l_ext = ( $1.ext ? $1.ext : '\0' );
result->u_ext = '-';
}
| RANGE boundary
{
result->lower = -HUGE_VAL;
result->upper = $2.val;
result->l_sigd = 0;
result->u_sigd = $2.sigd;
result->l_ext = '-';
result->u_ext = ( $2.ext ? $2.ext : '\0' );
}
| boundary
{
result->lower = result->upper = $1.val;
result->l_sigd = result->u_sigd = $1.sigd;
result->l_ext = result->u_ext = ( $1.ext ? $1.ext : '\0' );
}
;
boundary: SEGFLOAT
{
/* temp variable avoids a gcc 3.3.x bug on Sparc64 */
float val;
if (!seg_atof($1, &val, escontext))
YYABORT;
$$.ext = '\0';
$$.sigd = sig_digits($1);
$$.val = val;
}
| EXTENSION SEGFLOAT
{
/* temp variable avoids a gcc 3.3.x bug on Sparc64 */
float val;
if (!seg_atof($2, &val, escontext))
YYABORT;
$$.ext = $1[0];
$$.sigd = sig_digits($2);
$$.val = val;
}
;
deviation: SEGFLOAT
{
/* temp variable avoids a gcc 3.3.x bug on Sparc64 */
float val;
if (!seg_atof($1, &val, escontext))
YYABORT;
$$.ext = '\0';
$$.sigd = sig_digits($1);
$$.val = val;
}
;
%%
static bool
seg_atof(char *value, float *result, struct Node *escontext)
{
*result = float4in_internal(value, NULL, "seg", value, escontext);
if (SOFT_ERROR_OCCURRED(escontext))
return false;
return true;
}
static int
sig_digits(const char *value)
{
int n = significant_digits(value);
/* Clamp, to ensure value will fit in sigd fields */
return Min(n, FLT_DIG);
}