postgres

mirror of https://github.com/postgres/postgres.git synced 2025-06-04 12:42:24 +03:00

History

Tom Lane a94f51a7bf Fix unnecessary use of moving-aggregate mode with non-moving frame.

When a plain aggregate is used as a window function, and the window
frame start is specified as UNBOUNDED PRECEDING, the frame's head
cannot move so we do not need to use moving-aggregate mode.  The check
for that was put into initialize_peragg(), failing to notice that
ExecInitWindowAgg() calls that function before it's filled in
winstate->frameOptions.  Since makeNode() would have zeroed the field,
this didn't provoke uninitialized-value complaints, nor would the
erroneous decision have resulted in more than a little inefficiency.
Still, it's wrong, so move the initialization of
winstate->frameOptions earlier to make it work properly.

While here, also fix a thinko in a comment.  Both errors crept in in
commit a9d9acbf2 which introduced the moving-aggregate mode.

Spotted by Vallimaharajan G.  Back-patch to all supported branches.

Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469143@zohocorp.com

2024-03-27 13:39:03 -04:00

backend

Fix unnecessary use of moving-aggregate mode with non-moving frame.

2024-03-27 13:39:03 -04:00

bin

Fix dumping role comments when using --no-role-passwords

2024-03-21 23:31:57 +01:00

common

Move is_valid_ascii() to ascii.h.

2024-01-29 12:09:03 -06:00

fe_utils

Don't spuriously report FD_SETSIZE exhaustion on Windows.