1
0
mirror of https://github.com/postgres/postgres.git synced 2025-05-01 01:04:50 +03:00
Andrew Gierth 64eed263ac postgres_fdw: don't push ORDER BY with no vars (bug #15352)
Commit aa09cd242 changed a condition in find_em_expr_for_rel from
being a bms_equal comparison of relids to bms_is_subset, in order to
support order by clauses on foreign joins. But this also allows
through the degenerate case of expressions with no Vars at all (and
hence empty relids), including integer constants which will be parsed
unexpectedly on the remote (viz. "ERROR: ORDER BY position 0 is not in
select list" as in the bug report).

Repair by adding an additional !bms_is_empty test.

Backpatch through to 9.6 where the aforementioned change was made.

Per bug #15352 from Maksym Boguk; analysis and patch by me.

Discussion: https://postgr.es/m/153518420278.1478.14875560810251994661@wrigleys.postgresql.org
2018-08-28 15:04:24 +01:00
..
2017-06-21 15:35:54 -04:00
2017-06-21 15:35:54 -04:00
2018-07-18 16:18:27 +03:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:19:25 -04:00
2017-03-30 14:18:53 -04:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:35:54 -04:00
2017-06-21 15:19:25 -04:00
2017-06-21 15:35:54 -04:00
2017-03-09 16:33:02 -08:00

The PostgreSQL contrib tree
---------------------------

This subtree contains porting tools, analysis utilities, and plug-in
features that are not part of the core PostgreSQL system, mainly
because they address a limited audience or are too experimental to be
part of the main source tree.  This does not preclude their
usefulness.

User documentation for each module appears in the main SGML
documentation.

When building from the source distribution, these modules are not
built automatically, unless you build the "world" target.  You can
also build and install them all by running "make all" and "make
install" in this directory; or to build and install just one selected
module, do the same in that module's subdirectory.

Some directories supply new user-defined functions, operators, or
types.  To make use of one of these modules, after you have installed
the code you need to register the new SQL objects in the database
system by executing a CREATE EXTENSION command.  In a fresh database,
you can simply do

    CREATE EXTENSION module_name;

See the PostgreSQL documentation for more information about this
procedure.