mirror of
https://github.com/postgres/postgres.git
synced 2025-06-01 14:21:49 +03:00
0028b55bc8
Fix pthread-win32.h and pthread-win32.c to provide a more complete emulation of POSIX pthread mutexes: define PTHREAD_MUTEX_INITIALIZER and make sure that pthread_mutex_lock() can operate on a mutex object that's been initialized that way. Then we don't need the duplicative platform-specific logic in default_threadlock() and pgtls_init(), which we'd otherwise need yet a third copy of for an upcoming bug fix. Also, since default_threadlock() supposes that pthread_mutex_lock() cannot fail, try to ensure that that's actually true, by getting rid of the malloc call that was formerly involved in initializing an emulated mutex. We can define an extra state for the spinlock field instead. Also, replace the similar code in ecpglib/misc.c with this version. While ecpglib's version at least had a POSIX-compliant API, it also had the potential of failing during mutex init (but here, because of CreateMutex failure rather than malloc failure). Since all of misc.c's callers ignore failures, it seems like a wise idea to avoid failures here too. A further improvement in this area could be to unify libpq's and ecpglib's implementations into a src/port/pthread-win32.c file. But that doesn't seem like a bug fix, so I'll desist for now. In preparation for the aforementioned bug fix, back-patch to all supported branches. Discussion: https://postgr.es/m/264860.1707163416@sss.pgh.pa.us
32 lines
645 B
C
32 lines
645 B
C
/*
|
|
* src/port/pthread-win32.h
|
|
*/
|
|
#ifndef __PTHREAD_H
|
|
#define __PTHREAD_H
|
|
|
|
typedef ULONG pthread_key_t;
|
|
|
|
typedef struct pthread_mutex_t
|
|
{
|
|
/* initstate = 0: not initialized; 1: init done; 2: init in progress */
|
|
LONG initstate;
|
|
CRITICAL_SECTION csection;
|
|
} pthread_mutex_t;
|
|
|
|
#define PTHREAD_MUTEX_INITIALIZER { 0 }
|
|
|
|
typedef int pthread_once_t;
|
|
|
|
DWORD pthread_self(void);
|
|
|
|
void pthread_setspecific(pthread_key_t, void *);
|
|
void *pthread_getspecific(pthread_key_t);
|
|
|
|
int pthread_mutex_init(pthread_mutex_t *, void *attr);
|
|
int pthread_mutex_lock(pthread_mutex_t *);
|
|
|
|
/* blocking */
|
|
int pthread_mutex_unlock(pthread_mutex_t *);
|
|
|
|
#endif
|