mirror of
https://github.com/postgres/postgres.git
synced 2026-10-23 13:29:09 +03:00
755f7e2c92
Virtual generated columns are stored in tuples as null values, so heap_getattr() in tuple_to_stringinfo() always returns null for them. test_decoding printed such a column as null, which is indistinguishable from a column that genuinely holds null. This commit skips virtual generated columns in tuple_to_stringinfo(), the only place that prints a tuple. Stored generated columns continue to be printed, since their values do live in the heap tuple. This is a behavior change rather than a bug fix, and it changes test_decoding's output for tables that have virtual generated columns, which could affect consumers that parse it. Therefore it is not back-patched. Author: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com> Co-authored-by: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> Reviewed-by: Euler Taveira <euler@eulerto.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Discussion: https://postgr.es/m/CAHg+QDfTh3UbB-Ed--o2Bd=SBDJoEiG-qp3C0+ETDibF63y=dw@mail.gmail.com