mirror of
https://github.com/postgres/postgres.git
synced 2025-06-22 02:52:08 +03:00
be6aadf07d
The assert, introduced by 9f1cf97bb5, is intended to check if the prefix
is terminated by a \0 byte, but it has two flaws. Firstly, prefix_size
includes the \0 byte, so prefix[prefix_size] points to the byte after
the null byte. Secondly, the check ensures the byte is not equal \0,
while it should be checking the opposite.
Backpatch-through: 14
Discussion: https://postgr.es/m/b99b6101-2f14-3796-3dfa-4a6cd7d4326d@enterprisedb.com
53 lines
1.4 KiB
C
53 lines
1.4 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* logicalmsgdesc.c
|
|
* rmgr descriptor routines for replication/logical/message.c
|
|
*
|
|
* Portions Copyright (c) 2015-2022, PostgreSQL Global Development Group
|
|
*
|
|
*
|
|
* IDENTIFICATION
|
|
* src/backend/access/rmgrdesc/logicalmsgdesc.c
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#include "postgres.h"
|
|
|
|
#include "replication/message.h"
|
|
|
|
void
|
|
logicalmsg_desc(StringInfo buf, XLogReaderState *record)
|
|
{
|
|
char *rec = XLogRecGetData(record);
|
|
uint8 info = XLogRecGetInfo(record) & ~XLR_INFO_MASK;
|
|
|
|
if (info == XLOG_LOGICAL_MESSAGE)
|
|
{
|
|
xl_logical_message *xlrec = (xl_logical_message *) rec;
|
|
char *prefix = xlrec->message;
|
|
char *message = xlrec->message + xlrec->prefix_size;
|
|
char *sep = "";
|
|
|
|
Assert(prefix[xlrec->prefix_size - 1] == '\0');
|
|
|
|
appendStringInfo(buf, "%s, prefix \"%s\"; payload (%zu bytes): ",
|
|
xlrec->transactional ? "transactional" : "non-transactional",
|
|
prefix, xlrec->message_size);
|
|
/* Write message payload as a series of hex bytes */
|
|
for (int cnt = 0; cnt < xlrec->message_size; cnt++)
|
|
{
|
|
appendStringInfo(buf, "%s%02X", sep, (unsigned char) message[cnt]);
|
|
sep = " ";
|
|
}
|
|
}
|
|
}
|
|
|
|
const char *
|
|
logicalmsg_identify(uint8 info)
|
|
{
|
|
if ((info & ~XLR_INFO_MASK) == XLOG_LOGICAL_MESSAGE)
|
|
return "MESSAGE";
|
|
|
|
return NULL;
|
|
}
|