Andres Freund b8607e15e0 Don't access catalogs to validate GUCs when not connected to a DB. ...

Vignesh found this bug in the check function for
default_table_access_method's check hook, but that was just copied
from older GUCs. Investigation by Michael and me then found the bug in
further places.

When not connected to a database (e.g. in a walsender connection), we
cannot perform (most) GUC checks that need database access. Even when
only shared tables are needed, unless they're
nailed (c.f. RelationCacheInitializePhase2()), they cannot be accessed
without pg_class etc. being present.

Fix by extending the existing IsTransactionState() checks to also
check for MyDatabaseOid.

Reported-By: Vignesh C, Michael Paquier, Andres Freund
Author: Vignesh C, Andres Freund
Discussion: https://postgr.es/m/CALDaNm1KXK9gbZfY-p_peRFm_XrBh1OwQO1Kk6Gig0c0fVZ2uw%40mail.gmail.com
Backpatch: 9.4-

2019-06-10 23:36:55 -07:00

..

aggregatecmds.c

Fix type-safety problem with parallel aggregate serial/deserialization.

2016-06-22 16:52:41 -04:00

alter.c

pgindent run for 9.6

2016-06-09 18:02:36 -04:00

amcmds.c

Fix typos in comments.

2017-02-06 11:34:15 +02:00

analyze.c

Improve ANALYZE's handling of concurrent-update scenarios.

2019-01-03 17:00:08 -05:00

async.c

Fix low-probability loss of NOTIFY messages due to XID wraparound.

2017-10-11 14:28:33 -04:00

cluster.c

Fix misc typos, mostly in comments.

2018-07-18 16:20:18 +03:00

collationcmds.c

Update copyright for 2016

2016-01-02 13:33:40 -05:00

comment.c

Update copyright for 2016

2016-01-02 13:33:40 -05:00

constraint.c

Update copyright for 2016

2016-01-02 13:33:40 -05:00

conversioncmds.c

pgindent run for 9.6

2016-06-09 18:02:36 -04:00

copy.c

Widen COPY FROM's current-line-number counter from 32 to 64 bits.

2018-05-22 13:32:52 -04:00

createas.c

Fix CREATE MATVIEW/CREATE TABLE AS ... WITH NO DATA to not plan the query.

2016-06-27 15:57:50 -04:00

dbcommands.c

Fix typos in comments.

2017-02-06 11:34:15 +02:00

define.c

Update copyright for 2016

2016-01-02 13:33:40 -05:00

discard.c

Update copyright for 2016

2016-01-02 13:33:40 -05:00

dropcmds.c

Fix DROP ACCESS METHOD IF EXISTS.

2016-05-27 11:03:18 -04:00

event_trigger.c

Silence compiler warning in Assert()

2018-10-08 10:37:21 -03:00

explain.c

Fix typos in comments.

2017-02-06 11:34:15 +02:00

extension.c

Ensure commands in extension scripts see the results of preceding DDL.

2017-05-02 18:05:54 -04:00

foreigncmds.c

Don't record FDW user mappings as members of extensions.

2018-08-07 16:33:03 -04:00

functioncmds.c

Fix dependency, when changing a function's argument/return type.

2017-06-16 11:39:45 +03:00

indexcmds.c

Fix event triggers for partitioned tables

2018-10-06 19:17:46 -03:00

lockcmds.c

Update copyright for 2016

2016-01-02 13:33:40 -05:00

Makefile

Support CREATE ACCESS METHOD

2016-03-23 23:01:35 -03:00

matview.c

Fix some corner-case issues in REFRESH MATERIALIZED VIEW CONCURRENTLY.

2018-03-19 18:49:53 -04:00

opclasscmds.c

Add SQL-accessible functions for inspecting index AM properties.

2016-08-13 18:31:14 -04:00

operatorcmds.c

pgindent run for 9.6

2016-06-09 18:02:36 -04:00

policy.c

Add macros to make AllocSetContextCreate() calls simpler and safer.

2016-08-27 17:50:38 -04:00

portalcmds.c

Fix TOAST access failure in RETURNING queries.

2016-08-07 17:46:08 -04:00

prepare.c

Fix interaction of parallel query with prepared statements.

2016-12-06 11:43:12 -05:00

proclang.c

pgindent run for 9.6

2016-06-09 18:02:36 -04:00

schemacmds.c

Remove various special checks around default roles

2016-05-06 14:06:50 -04:00

seclabel.c

Update copyright for 2016

2016-01-02 13:33:40 -05:00

sequence.c

Revert no-op changes to BufferGetPage()

2016-04-20 08:31:19 -05:00

tablecmds.c

Ignore inherited temp relations from other sessions when truncating

2018-12-27 10:17:21 +09:00

tablespace.c

Don't access catalogs to validate GUCs when not connected to a DB.

2019-06-10 23:36:55 -07:00

trigger.c

Prevent dangling-pointer access when update trigger returns old tuple.

2018-02-27 13:27:38 -05:00

tsearchcmds.c

Use TSConfigRelationId in AlterTSConfiguration()

2016-12-22 17:08:47 -05:00

typecmds.c

Fix missing role dependencies for some schema and type ACLs.

2018-11-09 20:42:03 -05:00

user.c

pgindent run for 9.6

2016-06-09 18:02:36 -04:00

vacuum.c

When updating reltuples after ANALYZE, just extrapolate from our sample.

2018-03-13 13:24:27 -04:00

vacuumlazy.c

Perform a lot more sanity checks when freezing tuples.

2017-12-14 18:20:48 -08:00

variable.c

Assorted translatable string fixes

2017-06-04 11:41:16 -04:00

view.c

Fix CREATE VIEW to allow zero-column views.

2019-02-17 12:37:32 -05:00