mirror of
https://github.com/postgres/postgres.git
synced 2025-05-06 19:59:18 +03:00
aae40cf13b
We were passing error message texts to croak() verbatim, which turns out not to work if the text contains non-ASCII characters; Perl mangles their encoding, as reported in bug #13638 from Michal Leinweber. To fix, convert the text into a UTF8-encoded SV first. It's hard to test this without risking failures in different database encodings; but we can follow the lead of plpython, which is already assuming that no-break space (U+00A0) has an equivalent in all encodings we care about running the regression tests in (cf commit 2dfa15de5). Back-patch to 9.1. The code is quite different in 9.0, and anyway it seems too risky to put something like this into 9.0's final minor release. Alex Hunsaker, with suggestions from Tim Bunce and Tom Lane
94 lines
2.0 KiB
PL/PgSQL
94 lines
2.0 KiB
PL/PgSQL
-- test warnings and errors from plperl
|
||
|
||
create or replace function perl_elog(text) returns void language plperl as $$
|
||
|
||
my $msg = shift;
|
||
elog(NOTICE,$msg);
|
||
|
||
$$;
|
||
|
||
select perl_elog('explicit elog');
|
||
|
||
create or replace function perl_warn(text) returns void language plperl as $$
|
||
|
||
my $msg = shift;
|
||
warn($msg);
|
||
|
||
$$;
|
||
|
||
select perl_warn('implicit elog via warn');
|
||
|
||
-- test strict mode on/off
|
||
|
||
SET plperl.use_strict = true;
|
||
|
||
create or replace function uses_global() returns text language plperl as $$
|
||
|
||
$global = 1;
|
||
$other_global = 2;
|
||
return 'uses_global worked';
|
||
|
||
$$;
|
||
|
||
select uses_global();
|
||
|
||
SET plperl.use_strict = false;
|
||
|
||
create or replace function uses_global() returns text language plperl as $$
|
||
|
||
$global = 1;
|
||
$other_global=2;
|
||
return 'uses_global worked';
|
||
|
||
$$;
|
||
|
||
select uses_global();
|
||
|
||
-- make sure we don't choke on readonly values
|
||
do language plperl $$ elog(NOTICE, ${^TAINT}); $$;
|
||
|
||
-- test recovery after "die"
|
||
|
||
create or replace function just_die() returns void language plperl AS $$
|
||
die "just die";
|
||
$$;
|
||
|
||
select just_die();
|
||
|
||
create or replace function die_caller() returns int language plpgsql as $$
|
||
BEGIN
|
||
BEGIN
|
||
PERFORM just_die();
|
||
EXCEPTION WHEN OTHERS THEN
|
||
RAISE NOTICE 'caught die';
|
||
END;
|
||
RETURN 1;
|
||
END;
|
||
$$;
|
||
|
||
select die_caller();
|
||
|
||
create or replace function indirect_die_caller() returns int language plperl as $$
|
||
my $prepared = spi_prepare('SELECT die_caller() AS fx');
|
||
my $a = spi_exec_prepared($prepared)->{rows}->[0]->{fx};
|
||
my $b = spi_exec_prepared($prepared)->{rows}->[0]->{fx};
|
||
return $a + $b;
|
||
$$;
|
||
|
||
select indirect_die_caller();
|
||
|
||
-- Test non-ASCII error messages
|
||
--
|
||
-- Note: this test case is known to fail if the database encoding is
|
||
-- EUC_CN, EUC_JP, EUC_KR, or EUC_TW, for lack of any equivalent to
|
||
-- U+00A0 (no-break space) in those encodings. However, testing with
|
||
-- plain ASCII data would be rather useless, so we must live with that.
|
||
|
||
SET client_encoding TO UTF8;
|
||
|
||
create or replace function error_with_nbsp() returns void language plperl as $$
|
||
elog(ERROR, "this message contains a no-break space");
|
||
$$;
|
||
|
||
select error_with_nbsp();
|