Dean Rasheed a93e2a1e25 Fix JsonExpr deparsing to quote variable names in the PASSING clause. ...

When deparsing a JsonExpr, variable names in the PASSING clause were
not quoted. However, since they are parsed as ColLabel tokens, some
variable names require double quotes to ensure that they are properly
interpreted. Fix by using quote_identifier() in the deparsing code.

This oversight was limited to the SQL/JSON query functions
JSON_EXISTS(), JSON_QUERY(), and JSON_VALUE().

Back-patch to v17, where these functions were added.

Dean Rasheed, reviewed by Tom Lane.

Discussion: https://postgr.es/m/CAEZATCXTpAS%3DncfLNTZ7YS6O5puHeLg_SUYAit%2Bcs7wsrd9Msg%40mail.gmail.com

2025-01-12 13:35:12 +00:00

..

advisory_lock.sql

…

aggregates.sql

Detect redundant GROUP BY columns using UNIQUE indexes

2024-12-12 15:28:38 +13:00

alter_generic.sql

…

alter_operator.sql

Extend ALTER OPERATOR to allow setting more optimization attributes.

2023-10-20 12:28:46 -04:00

alter_table.sql

Add support for NOT ENFORCED in CHECK constraints

2025-01-11 10:52:30 +01:00

amutils.sql

…

arrays.sql

Add missing newlines at the end of two SQL files

2024-11-03 19:42:51 +09:00

async.sql

…

bit.sql

Optimize pg_popcount() with AVX-512 instructions.

2024-04-06 21:56:23 -05:00

bitmapops.sql

…

boolean.sql

Add tests for int4_bool() in int.c

2024-01-31 15:02:28 +09:00

box.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

brin_bloom.sql

…

brin_multi.sql

Enable BUFFERS with EXPLAIN ANALYZE by default

2024-12-11 22:35:11 +13:00

brin.sql

Set query ID in parallel workers for vacuum, BRIN and btree

2024-09-30 08:43:28 +09:00

btree_index.sql

Improve nbtree unsatisfiable RowCompare detection.

2025-01-07 10:38:30 -05:00

case.sql

Fix NULLIF()'s handling of read-write expanded objects.

2024-11-25 18:09:09 -05:00

char.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

circle.sql

…

cluster.sql

Reintroduce MAINTAIN privilege and pg_maintain predefined role.

2024-03-13 14:49:26 -05:00

collate.icu.utf8.sql

Add tests for foreign keys with case-insensitive collations

2024-11-29 08:52:55 +01:00

collate.linux.utf8.sql

Remove read-only server settings lc_collate and lc_ctype

2023-06-07 16:57:06 +02:00

collate.sql

Introduce "builtin" collation provider.

2024-03-13 23:33:44 -07:00

collate.utf8.sql

Make collation not depend on setlocale().

2024-07-30 00:58:06 -07:00

collate.windows.win1252.sql

Fix collate.windows.win1252 test.

2023-12-29 11:26:10 -08:00

combocid.sql

…

comments.sql

…

compression.sql

Fix segmentation fault in MergeInheritedAttribute()

2024-05-03 11:10:40 +02:00

constraints.sql

Add support for NOT ENFORCED in CHECK constraints

2025-01-11 10:52:30 +01:00

conversion.sql

…

copy2.sql

Fix validation of COPY FORCE_NOT_NULL/FORCE_NULL for the all-column cases

2024-10-17 08:44:50 +09:00

copy.sql

Reject a copy EOF marker that has data ahead of it on the same line.

2024-10-01 16:53:54 -04:00

copydml.sql

Fix wrong assertion and poor error messages in "COPY (query) TO".

2024-10-21 15:08:22 -04:00

copyencoding.sql

Add some tests for encoding conversion in COPY TO/FROM

2024-12-16 11:23:38 +09:00

copyselect.sql

…

create_aggregate.sql

…

create_am.sql

Fix dependency of partitioned table and table AM with CREATE TABLE .. USING

2024-10-29 08:41:33 +09:00

create_cast.sql

…

create_function_c.sql

…

create_function_sql.sql

…

create_index_spgist.sql

…

create_index.sql

Improve nbtree unsatisfiable RowCompare detection.

2025-01-07 10:38:30 -05:00

create_misc.sql

…

create_operator.sql

Extend ALTER OPERATOR to allow setting more optimization attributes.

2023-10-20 12:28:46 -04:00

create_procedure.sql

Fix failure with SQL-procedure polymorphic output arguments in v12.

2024-06-06 15:16:56 -04:00

create_role.sql

Fix DROP ROLE when specifying duplicated roles

2024-01-29 08:05:59 +09:00

create_schema.sql

Fix crashes with CREATE SCHEMA AUTHORIZATION and schema elements

2023-04-28 19:29:12 +09:00

create_table_like.sql

Add support for NOT ENFORCED in CHECK constraints

2025-01-11 10:52:30 +01:00

create_table.sql

Remove support for unlogged on partitioned tables

2024-10-03 10:55:02 +09:00

create_type.sql

…

create_view.sql

Fix mis-deparsing of ORDER BY lists when there is a name conflict.

2024-08-29 13:24:17 -04:00

database.sql

In REASSIGN OWNED of a database, lock the tuple as mandated.

2024-12-28 07:16:22 -08:00

date.sql

Fix various overflow hazards in date and timestamp functions.

2024-12-09 13:47:23 -06:00

dbsize.sql

Fix incorrect return value for pg_size_pretty(bigint)

2024-07-28 22:22:52 +12:00

delete.sql

…

dependency.sql

Reintroduce MAINTAIN privilege and pg_maintain predefined role.

2024-03-13 14:49:26 -05:00

domain.sql

Add support for NOT ENFORCED in CHECK constraints

2025-01-11 10:52:30 +01:00

drop_if_exists.sql

…

drop_operator.sql

…

enum.sql

Allow more cases to pass the unsafe-use-of-new-enum-value restriction.

2024-03-24 14:30:29 -04:00

equivclass.sql

Check the validity of commutators for merge/hash clauses

2024-09-04 12:17:11 +09:00

errors.sql

…

event_trigger_login.sql

Remove the flaky check in event_trigger_login regression test

2024-01-17 23:16:53 +02:00

event_trigger.sql

Fix assertion failure with REINDEX and event triggers

2023-12-07 08:31:02 +09:00

explain.sql

Enable BUFFERS with EXPLAIN ANALYZE by default

2024-12-11 22:35:11 +13:00

expressions.sql

Add back SQLValueFunction for SQL keywords

2023-05-17 10:19:17 +09:00

fast_default.sql

Ensure we preprocess expressions before checking their volatility.

2023-11-16 10:05:14 -05:00

float4.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

float8.sql

Add some regression tests for missing DDL patterns

2024-12-12 11:16:45 +09:00

foreign_data.sql

Fix failure of ALTER FOREIGN TABLE SET SCHEMA to move sequences.

2024-03-26 15:28:31 -04:00

foreign_key.sql

Fix some more bugs in foreign keys connecting partitioned tables

2024-10-30 10:54:03 +01:00

functional_deps.sql

…

generated_stored.sql

Put generated_stored test objects in a schema

2024-08-29 12:24:47 +02:00

geometry.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

gin.sql

…

gist.sql

…

groupingsets.sql

Allow pushdown of HAVING clauses with grouping sets

2024-10-09 17:19:04 +09:00

guc.sql

Apply GUC name from central table in more places of guc.c

2024-10-09 18:47:34 +09:00

hash_func.sql

Reduce dependency to money data type in main regression test suite

2024-01-15 09:30:16 +09:00

hash_index.sql

Fix an uninitialized access in hash_xlog_squeeze_page().

2023-12-01 10:22:13 +05:30

hash_part.sql

Update comments to match location of definition

2023-09-06 10:18:30 +02:00

horology.sql

Fix various overflow hazards in date and timestamp functions.

2024-12-09 13:47:23 -06:00

identity.sql

Add some regression tests for missing DDL patterns

2024-12-12 11:16:45 +09:00

incremental_sort.sql

Enable BUFFERS with EXPLAIN ANALYZE by default

2024-12-11 22:35:11 +13:00

index_including_gist.sql

…

index_including.sql

Add pg_constraint rows for not-null constraints

2024-11-08 13:28:48 +01:00

indexing.sql

Add pg_constraint rows for not-null constraints

2024-11-08 13:28:48 +01:00

indirect_toast.sql

…

inet.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

infinite_recurse.sql

…

inherit.sql

Add support for NOT ENFORCED in CHECK constraints

2025-01-11 10:52:30 +01:00

init_privs.sql

…

insert_conflict.sql

Fix infer_arbiter_indexes() to not assume resultRelation is 1.

2024-06-11 17:57:46 -04:00

insert.sql

Make INSERT-from-multiple-VALUES-rows handle domain target columns.

2024-03-14 14:57:16 -04:00

int2.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

int4.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

int8.sql

Modernize to_char's Roman-numeral code, fixing overflow problems.

2024-09-26 11:02:31 -04:00

interval.sql

Improve handling of date_trunc() units for infinite input values

2024-12-27 13:32:40 +09:00

join_hash.sql

Fix hash join when inner hashkey expressions contain Params.

2023-06-20 17:47:53 -04:00

join.sql

Ignore nullingrels when looking up statistics

2025-01-02 18:06:00 +09:00

json_encoding.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

json.sql

Fix unique key checks in JSON object constructors

2024-09-11 13:21:10 +02:00

jsonb_jsonpath.sql

Stabilize jsonb_path_query test case.

2024-10-30 11:42:34 -04:00

jsonb.sql

Remove dependence on -fwrapv semantics in jsonb.

2024-08-16 11:24:44 -05:00

jsonpath_encoding.sql

…

jsonpath.sql

Implement various jsonpath methods

2024-01-25 10:15:43 -05:00

largeobject.sql

Fix bugs in manipulation of large objects.

2023-12-15 13:55:05 -05:00

limit.sql

…

line.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

lock.sql

…

lseg.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

macaddr8.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

macaddr.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

matview.sql

Add missing BUFFERS OFF in regression tests, take 2

2024-12-11 23:16:44 +13:00

md5.sql

…

memoize.sql

Enable BUFFERS with EXPLAIN ANALYZE by default

2024-12-11 22:35:11 +13:00

merge.sql

Enable BUFFERS with EXPLAIN ANALYZE by default

2024-12-11 22:35:11 +13:00

misc_functions.sql

Add missing BUFFERS OFF in regression tests, take 2

2024-12-11 23:16:44 +13:00

misc_sanity.sql

Remove pg_authid's TOAST table.

2024-09-21 15:17:46 -05:00

misc.sql

…

money.sql

Add overflow checks to money type.

2024-07-19 11:52:32 -05:00

multirangetypes.sql

Fix multiranges to behave more like dependent types.

2024-02-14 11:30:39 -05:00

mvcc.sql

…

name.sql

…

namespace.sql

Fix search_path to a safe value during maintenance operations.

2024-03-04 17:31:38 -08:00

numeric_big.sql

…

numeric.sql

Speed up numeric division by always using the "fast" algorithm.

2024-10-04 09:49:24 +01:00

numerology.sql

Fix overflow in parsing of positional parameter

2024-07-02 09:29:26 +02:00

object_address.sql

…

oid.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

oidjoins.sql

…

opr_sanity.sql

Unmark gen_random_uuid() function leakproof.

2024-12-11 10:35:57 -08:00

partition_aggregate.sql

…

partition_info.sql

…

partition_join.sql

Fix partitionwise join with partially-redundant join clauses

2024-07-30 15:51:54 +09:00

partition_prune.sql

Enable BUFFERS with EXPLAIN ANALYZE by default

2024-12-11 22:35:11 +13:00

password.sql

Restrict password hash length.

2024-10-07 10:56:16 -05:00

path.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

pg_lsn.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

plancache.sql

…

plpgsql.sql

Fix plpgsql's handling of -- comments following expressions.

2024-04-10 15:45:58 -04:00

point.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

polygon.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

polymorphism.sql

…

portals_p2.sql

…

portals.sql

…

predicate.sql

Fix inconsistent RestrictInfo serial numbers

2024-11-08 11:21:11 +09:00

prepare.sql

Remove too demanding test

2024-07-02 10:43:12 +02:00

prepared_xacts.sql

Make two-phase tests of ECPG and main suite more concurrent-proof

2024-04-29 21:10:41 +09:00

privileges.sql

Fix an ALTER GROUP ... DROP USER error message.

2025-01-09 17:10:13 -06:00

psql_crosstab.sql

…

psql.sql

psql: Add tests for repeated calls of \bind[_named]

2024-09-20 08:59:20 +09:00

publication.sql

Ensure stored generated columns must be published when required.

2024-12-04 09:45:18 +05:30

random.sql

Add functions to generate random numbers in a specified range.

2024-03-27 10:12:39 +00:00

rangefuncs.sql

Fix type-checking of RECORD-returning functions in FROM, redux.

2024-04-15 12:56:56 -04:00

rangetypes.sql

Add planner support functions for range operators <@ and @>.

2024-01-20 13:57:54 -05:00

regex.sql

…

regproc.sql

Add to_regtypemod function to extract typemod from a string type name.

2024-03-20 17:11:28 -04:00

reindex_catalog.sql

…

reloptions.sql

Test that it works to RESET an invalid reloption

2023-12-08 11:58:58 +01:00

replica_identity.sql

Add pg_constraint rows for not-null constraints

2024-11-08 13:28:48 +01:00

returning.sql

…

roleattributes.sql

…

rowsecurity.sql

Transform OR-clauses to SAOP's during index matching

2024-11-24 01:40:20 +02:00

rowtypes.sql

Fix "failed to find plan for subquery/CTE" errors in EXPLAIN.

2024-08-09 11:21:39 -04:00

rules.sql

Add support for MERGE ... WHEN NOT MATCHED BY SOURCE.

2024-03-30 10:00:26 +00:00

sanity_check.sql

Remove AIX support

2024-02-28 15:17:23 +04:00

security_label.sql

…

select_distinct_on.sql

Fix test case from a8ccf4e93

2024-11-26 11:12:57 +09:00

select_distinct.sql

Reordering DISTINCT keys to match input path's pathkeys

2024-11-26 09:25:18 +09:00

select_having.sql

…

select_implicit.sql

…

select_into.sql

Add missing BUFFERS OFF in select_into regression tests

2024-12-11 22:56:36 +13:00

select_parallel.sql

Enable BUFFERS with EXPLAIN ANALYZE by default

2024-12-11 22:35:11 +13:00

select_views.sql

…

select.sql

Enable BUFFERS with EXPLAIN ANALYZE by default

2024-12-11 22:35:11 +13:00

sequence.sql

Rename pg_sequence_read_tuple() to pg_get_sequence_data()

2024-08-30 08:49:24 +09:00

spgist.sql

…

sqljson_jsontable.sql

SQL/JSON: Fix default ON ERROR behavior for JSON_TABLE

2024-09-06 13:25:53 +09:00

sqljson_queryfuncs.sql

Fix JsonExpr deparsing to quote variable names in the PASSING clause.

2025-01-12 13:35:12 +00:00

sqljson.sql

SQL/JSON: Fix some oversights in commit b6e1157e7

2024-10-20 12:20:55 +09:00

stats_ext.sql

Transform OR-clauses to SAOP's during index matching

2024-11-24 01:40:20 +02:00

stats_import.sql

Use in-place updates for pg_restore_relation_stats().

2024-12-10 16:30:37 -08:00

stats.sql

Relax regression test for fsync check of backend-level stats

2024-12-20 19:00:18 +09:00

strings.sql

Add user-callable CRC functions.

2024-08-12 10:35:06 -05:00

subscription.sql

Allow altering of two_phase option of a SUBSCRIPTION.

2024-07-24 10:13:36 +05:30

subselect.sql

Improve planner's handling of SetOp plans.

2024-12-19 17:02:25 -05:00

sysviews.sql

Remove "parent" column from pg_backend_memory_contexts

2024-08-12 15:42:16 +12:00

tablesample.sql

…

tablespace.sql

Avoid "you don't own a lock of type ExclusiveLock" in GRANT TABLESPACE.

2024-11-25 14:42:35 -08:00

temp.sql

Ensure we have a snapshot while dropping ON COMMIT DROP temp tables.

2023-10-16 14:06:14 -04:00

test_setup.sql

Mop-up for AIX-ectomy: remove now-dead test code.

2024-02-28 14:34:19 -05:00

text.sql

…

tid.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

tidrangescan.sql

…

tidscan.sql

Enable BUFFERS with EXPLAIN ANALYZE by default

2024-12-11 22:35:11 +13:00

time.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

timestamp.sql

Improve handling of date_trunc() units for infinite input values

2024-12-27 13:32:40 +09:00

timestamptz.sql

Improve handling of date_trunc() units for infinite input values

2024-12-27 13:32:40 +09:00

timetz.sql

Dodge a compiler bug affecting timetz_zone/timetz_izone.

2023-10-17 13:10:35 -04:00

transactions.sql

Fix COMMIT/ROLLBACK AND CHAIN in the presence of subtransactions.

2023-09-21 23:11:30 -04:00

triggers.sql

Disallow NAMEDTUPLESTORE RTEs in stored views, rules, etc.

2025-01-08 16:35:54 -05:00

truncate.sql

…

tsdicts.sql

Fix typos and duplicate words

2024-04-18 21:28:07 +02:00

tsearch.sql

Fix parsing of ignored operators in websearch_to_tsquery().

2024-06-13 20:35:02 -04:00

tsrf.sql

…

tstypes.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

tuplesort.sql

Improve test coverage in bump.c

2024-04-16 16:21:31 +12:00

txid.sql

…

type_sanity.sql

Remove pg_attribute.attcacheoff column

2024-12-20 23:22:37 +13:00

typed_table.sql

Clarify error message and documentation related to typed tables.

2024-07-26 12:39:45 -04:00

unicode.sql

Additional unicode primitive functions.

2023-11-01 22:47:06 -07:00

union.sql

Improve planner's handling of SetOp plans.

2024-12-19 17:02:25 -05:00

updatable_views.sql

Correctly check updatability of columns targeted by INSERT...DEFAULT.

2024-07-20 13:40:15 -04:00

update.sql

Add hint about not qualifying UPDATE...SET target with relation name.

2024-01-20 17:54:14 -05:00

uuid.sql

Add UUID version 7 generation function.

2024-12-11 15:54:41 -08:00

vacuum_parallel.sql

…

vacuum.sql

Add ONLY support for VACUUM and ANALYZE

2024-09-24 18:03:40 +12:00

varchar.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

window.sql

Fix possible crash during WindowAgg evaluation

2024-12-09 14:23:21 +13:00

with.sql

Fix Assert failure in WITH RECURSIVE UNION queries

2024-12-19 13:11:39 +13:00

without_overlaps.sql

Fix ALTER TABLE / REPLICA IDENTITY for temporal tables

2024-11-21 13:50:18 +01:00

write_parallel.sql

…

xid.sql

Rework pg_input_error_message(), now renamed pg_input_error_info()

2023-02-28 08:04:13 +09:00

xml.sql

Fix XMLTABLE() deparsing to quote namespace names if necessary.

2025-01-12 12:54:32 +00:00

xmlmap.sql

…