mirror of
				https://github.com/postgres/postgres.git
				synced 2025-11-03 09:13:20 +03:00 
			
		
		
		
	Python 3 changed the behavior of PyMapping_Check(), breaking the test in plpython_to_hstore() that verifies whether a function result to be transformed is acceptable. A backwards-compatible fix is to first verify that the object doesn't pass PySequence_Check(). Perhaps accidentally, our other uses of PyMapping_Check() already follow uses of PySequence_Check(), so that no other bugs were created by this change. Per bug #17908 from Alexander Lakhin. Back-patch to all supported branches. Dmitry Dolgov and Tom Lane Discussion: https://postgr.es/m/17908-3f19a125d56a11d6@postgresql.org
		
			
				
	
	
		
			162 lines
		
	
	
		
			3.9 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			162 lines
		
	
	
		
			3.9 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
CREATE EXTENSION hstore_plpython2u CASCADE;
 | 
						|
NOTICE:  installing required extension "plpython2u"
 | 
						|
-- test hstore -> python
 | 
						|
CREATE FUNCTION test1(val hstore) RETURNS int
 | 
						|
LANGUAGE plpythonu
 | 
						|
TRANSFORM FOR TYPE hstore
 | 
						|
AS $$
 | 
						|
assert isinstance(val, dict)
 | 
						|
plpy.info(sorted(val.items()))
 | 
						|
return len(val)
 | 
						|
$$;
 | 
						|
SELECT test1('aa=>bb, cc=>NULL'::hstore);
 | 
						|
INFO:  [('aa', 'bb'), ('cc', None)]
 | 
						|
 test1 
 | 
						|
-------
 | 
						|
     2
 | 
						|
(1 row)
 | 
						|
 | 
						|
-- the same with the versioned language name
 | 
						|
CREATE FUNCTION test1n(val hstore) RETURNS int
 | 
						|
LANGUAGE plpython2u
 | 
						|
TRANSFORM FOR TYPE hstore
 | 
						|
AS $$
 | 
						|
assert isinstance(val, dict)
 | 
						|
plpy.info(sorted(val.items()))
 | 
						|
return len(val)
 | 
						|
$$;
 | 
						|
SELECT test1n('aa=>bb, cc=>NULL'::hstore);
 | 
						|
INFO:  [('aa', 'bb'), ('cc', None)]
 | 
						|
 test1n 
 | 
						|
--------
 | 
						|
      2
 | 
						|
(1 row)
 | 
						|
 | 
						|
-- test that a non-mapping result is correctly rejected
 | 
						|
CREATE FUNCTION test1bad() RETURNS hstore
 | 
						|
LANGUAGE plpythonu
 | 
						|
TRANSFORM FOR TYPE hstore
 | 
						|
AS $$
 | 
						|
return "foo"
 | 
						|
$$;
 | 
						|
SELECT test1bad();
 | 
						|
ERROR:  not a Python mapping
 | 
						|
CONTEXT:  while creating return value
 | 
						|
PL/Python function "test1bad"
 | 
						|
-- test hstore[] -> python
 | 
						|
CREATE FUNCTION test1arr(val hstore[]) RETURNS int
 | 
						|
LANGUAGE plpythonu
 | 
						|
TRANSFORM FOR TYPE hstore
 | 
						|
AS $$
 | 
						|
assert(val == [{'aa': 'bb', 'cc': None}, {'dd': 'ee'}])
 | 
						|
return len(val)
 | 
						|
$$;
 | 
						|
SELECT test1arr(array['aa=>bb, cc=>NULL'::hstore, 'dd=>ee']);
 | 
						|
 test1arr 
 | 
						|
----------
 | 
						|
        2
 | 
						|
(1 row)
 | 
						|
 | 
						|
-- test python -> hstore
 | 
						|
CREATE FUNCTION test2(a int, b text) RETURNS hstore
 | 
						|
LANGUAGE plpythonu
 | 
						|
TRANSFORM FOR TYPE hstore
 | 
						|
AS $$
 | 
						|
val = {'a': a, 'b': b, 'c': None}
 | 
						|
return val
 | 
						|
$$;
 | 
						|
SELECT test2(1, 'boo');
 | 
						|
              test2              
 | 
						|
---------------------------------
 | 
						|
 "a"=>"1", "b"=>"boo", "c"=>NULL
 | 
						|
(1 row)
 | 
						|
 | 
						|
--- test ruleutils
 | 
						|
\sf test2
 | 
						|
CREATE OR REPLACE FUNCTION public.test2(a integer, b text)
 | 
						|
 RETURNS hstore
 | 
						|
 TRANSFORM FOR TYPE hstore
 | 
						|
 LANGUAGE plpythonu
 | 
						|
AS $function$
 | 
						|
val = {'a': a, 'b': b, 'c': None}
 | 
						|
return val
 | 
						|
$function$
 | 
						|
-- test python -> hstore[]
 | 
						|
CREATE FUNCTION test2arr() RETURNS hstore[]
 | 
						|
LANGUAGE plpythonu
 | 
						|
TRANSFORM FOR TYPE hstore
 | 
						|
AS $$
 | 
						|
val = [{'a': 1, 'b': 'boo', 'c': None}, {'d': 2}]
 | 
						|
return val
 | 
						|
$$;
 | 
						|
SELECT test2arr();
 | 
						|
                           test2arr                           
 | 
						|
--------------------------------------------------------------
 | 
						|
 {"\"a\"=>\"1\", \"b\"=>\"boo\", \"c\"=>NULL","\"d\"=>\"2\""}
 | 
						|
(1 row)
 | 
						|
 | 
						|
-- test python -> domain over hstore
 | 
						|
CREATE DOMAIN hstore_foo AS hstore CHECK(VALUE ? 'foo');
 | 
						|
CREATE FUNCTION test2dom(fn text) RETURNS hstore_foo
 | 
						|
LANGUAGE plpythonu
 | 
						|
TRANSFORM FOR TYPE hstore
 | 
						|
AS $$
 | 
						|
return {'a': 1, fn: 'boo', 'c': None}
 | 
						|
$$;
 | 
						|
SELECT test2dom('foo');
 | 
						|
             test2dom              
 | 
						|
-----------------------------------
 | 
						|
 "a"=>"1", "c"=>NULL, "foo"=>"boo"
 | 
						|
(1 row)
 | 
						|
 | 
						|
SELECT test2dom('bar');  -- fail
 | 
						|
ERROR:  value for domain hstore_foo violates check constraint "hstore_foo_check"
 | 
						|
CONTEXT:  while creating return value
 | 
						|
PL/Python function "test2dom"
 | 
						|
-- test as part of prepare/execute
 | 
						|
CREATE FUNCTION test3() RETURNS void
 | 
						|
LANGUAGE plpythonu
 | 
						|
TRANSFORM FOR TYPE hstore
 | 
						|
AS $$
 | 
						|
rv = plpy.execute("SELECT 'aa=>bb, cc=>NULL'::hstore AS col1")
 | 
						|
assert(rv[0]["col1"] == {'aa': 'bb', 'cc': None})
 | 
						|
 | 
						|
val = {'a': 1, 'b': 'boo', 'c': None}
 | 
						|
plan = plpy.prepare("SELECT $1::text AS col1", ["hstore"])
 | 
						|
rv = plpy.execute(plan, [val])
 | 
						|
assert(rv[0]["col1"] == '"a"=>"1", "b"=>"boo", "c"=>NULL')
 | 
						|
$$;
 | 
						|
SELECT test3();
 | 
						|
 test3 
 | 
						|
-------
 | 
						|
 
 | 
						|
(1 row)
 | 
						|
 | 
						|
-- test trigger
 | 
						|
CREATE TABLE test1 (a int, b hstore);
 | 
						|
INSERT INTO test1 VALUES (1, 'aa=>bb, cc=>NULL');
 | 
						|
SELECT * FROM test1;
 | 
						|
 a |           b            
 | 
						|
---+------------------------
 | 
						|
 1 | "aa"=>"bb", "cc"=>NULL
 | 
						|
(1 row)
 | 
						|
 | 
						|
CREATE FUNCTION test4() RETURNS trigger
 | 
						|
LANGUAGE plpythonu
 | 
						|
TRANSFORM FOR TYPE hstore
 | 
						|
AS $$
 | 
						|
assert(TD["new"] == {'a': 1, 'b': {'aa': 'bb', 'cc': None}})
 | 
						|
if TD["new"]["a"] == 1:
 | 
						|
    TD["new"]["b"] = {'a': 1, 'b': 'boo', 'c': None}
 | 
						|
 | 
						|
return "MODIFY"
 | 
						|
$$;
 | 
						|
CREATE TRIGGER test4 BEFORE UPDATE ON test1 FOR EACH ROW EXECUTE PROCEDURE test4();
 | 
						|
UPDATE test1 SET a = a;
 | 
						|
SELECT * FROM test1;
 | 
						|
 a |                b                
 | 
						|
---+---------------------------------
 | 
						|
 1 | "a"=>"1", "b"=>"boo", "c"=>NULL
 | 
						|
(1 row)
 | 
						|
 |