mirror of
https://github.com/postgres/postgres.git
synced 2025-06-08 22:02:03 +03:00
9a3ddeb519
Commit 4ace45677 failed to fix the problem fully, because the same issue of attempting to fetch a non-returnable index column can occur when rechecking the indexqual after using a lossy index operator. Moreover, it broke EXPLAIN for such indexquals (which indicates a gap in our test cases :-(). Revert the code changes of 4ace45677 in favor of adding a new field to struct IndexOnlyScan, containing a version of the indexqual that can be executed against the index-returned tuple without using any non-returnable columns. (The restrictions imposed by check_index_only guarantee this is possible, although we may have to recompute indexed expressions.) Support construction of that during setrefs.c processing by marking IndexOnlyScan.indextlist entries as resjunk if they can't be returned, rather than removing them entirely. (We could alternatively require setrefs.c to look up the IndexOptInfo again, but abusing resjunk this way seems like a reasonably safe way to avoid needing to do that.) This solution isn't great from an API-stability standpoint: if there are any extensions out there that build IndexOnlyScan structs directly, they'll be broken in the next minor releases. However, only a very invasive extension would be likely to do such a thing. There's no change in the Path representation, so typical planner extensions shouldn't have a problem. As before, back-patch to all supported branches. Discussion: https://postgr.es/m/3179992.1641150853@sss.pgh.pa.us Discussion: https://postgr.es/m/17350-b5bdcf476e5badbb@postgresql.org
173 lines
5.8 KiB
SQL
173 lines
5.8 KiB
SQL
--
|
|
-- Test GiST indexes.
|
|
--
|
|
-- There are other tests to test different GiST opclasses. This is for
|
|
-- testing GiST code itself. Vacuuming in particular.
|
|
|
|
create table gist_point_tbl(id int4, p point);
|
|
create index gist_pointidx on gist_point_tbl using gist(p);
|
|
|
|
-- Verify the fillfactor and buffering options
|
|
create index gist_pointidx2 on gist_point_tbl using gist(p) with (buffering = on, fillfactor=50);
|
|
create index gist_pointidx3 on gist_point_tbl using gist(p) with (buffering = off);
|
|
create index gist_pointidx4 on gist_point_tbl using gist(p) with (buffering = auto);
|
|
drop index gist_pointidx2, gist_pointidx3, gist_pointidx4;
|
|
|
|
-- Make sure bad values are refused
|
|
create index gist_pointidx5 on gist_point_tbl using gist(p) with (buffering = invalid_value);
|
|
create index gist_pointidx5 on gist_point_tbl using gist(p) with (fillfactor=9);
|
|
create index gist_pointidx5 on gist_point_tbl using gist(p) with (fillfactor=101);
|
|
|
|
-- Insert enough data to create a tree that's a couple of levels deep.
|
|
insert into gist_point_tbl (id, p)
|
|
select g, point(g*10, g*10) from generate_series(1, 10000) g;
|
|
|
|
insert into gist_point_tbl (id, p)
|
|
select g+100000, point(g*10+1, g*10+1) from generate_series(1, 10000) g;
|
|
|
|
-- To test vacuum, delete some entries from all over the index.
|
|
delete from gist_point_tbl where id % 2 = 1;
|
|
|
|
-- And also delete some concentration of values.
|
|
delete from gist_point_tbl where id > 5000;
|
|
|
|
vacuum analyze gist_point_tbl;
|
|
|
|
-- rebuild the index with a different fillfactor
|
|
alter index gist_pointidx SET (fillfactor = 40);
|
|
reindex index gist_pointidx;
|
|
|
|
--
|
|
-- Test Index-only plans on GiST indexes
|
|
--
|
|
|
|
create table gist_tbl (b box, p point, c circle);
|
|
|
|
insert into gist_tbl
|
|
select box(point(0.05*i, 0.05*i), point(0.05*i, 0.05*i)),
|
|
point(0.05*i, 0.05*i),
|
|
circle(point(0.05*i, 0.05*i), 1.0)
|
|
from generate_series(0,10000) as i;
|
|
|
|
vacuum analyze gist_tbl;
|
|
|
|
set enable_seqscan=off;
|
|
set enable_bitmapscan=off;
|
|
set enable_indexonlyscan=on;
|
|
|
|
-- Test index-only scan with point opclass
|
|
create index gist_tbl_point_index on gist_tbl using gist (p);
|
|
|
|
-- check that the planner chooses an index-only scan
|
|
explain (costs off)
|
|
select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5));
|
|
|
|
-- execute the same
|
|
select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5));
|
|
|
|
-- Also test an index-only knn-search
|
|
explain (costs off)
|
|
select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5))
|
|
order by p <-> point(0.201, 0.201);
|
|
|
|
select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5))
|
|
order by p <-> point(0.201, 0.201);
|
|
|
|
-- Check commuted case as well
|
|
explain (costs off)
|
|
select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5))
|
|
order by point(0.101, 0.101) <-> p;
|
|
|
|
select p from gist_tbl where p <@ box(point(0,0), point(0.5, 0.5))
|
|
order by point(0.101, 0.101) <-> p;
|
|
|
|
-- Check case with multiple rescans (bug #14641)
|
|
explain (costs off)
|
|
select p from
|
|
(values (box(point(0,0), point(0.5,0.5))),
|
|
(box(point(0.5,0.5), point(0.75,0.75))),
|
|
(box(point(0.8,0.8), point(1.0,1.0)))) as v(bb)
|
|
cross join lateral
|
|
(select p from gist_tbl where p <@ bb order by p <-> bb[0] limit 2) ss;
|
|
|
|
select p from
|
|
(values (box(point(0,0), point(0.5,0.5))),
|
|
(box(point(0.5,0.5), point(0.75,0.75))),
|
|
(box(point(0.8,0.8), point(1.0,1.0)))) as v(bb)
|
|
cross join lateral
|
|
(select p from gist_tbl where p <@ bb order by p <-> bb[0] limit 2) ss;
|
|
|
|
drop index gist_tbl_point_index;
|
|
|
|
-- Test index-only scan with box opclass
|
|
create index gist_tbl_box_index on gist_tbl using gist (b);
|
|
|
|
-- check that the planner chooses an index-only scan
|
|
explain (costs off)
|
|
select b from gist_tbl where b <@ box(point(5,5), point(6,6));
|
|
|
|
-- execute the same
|
|
select b from gist_tbl where b <@ box(point(5,5), point(6,6));
|
|
|
|
-- Also test an index-only knn-search
|
|
explain (costs off)
|
|
select b from gist_tbl where b <@ box(point(5,5), point(6,6))
|
|
order by b <-> point(5.2, 5.91);
|
|
|
|
select b from gist_tbl where b <@ box(point(5,5), point(6,6))
|
|
order by b <-> point(5.2, 5.91);
|
|
|
|
-- Check commuted case as well
|
|
explain (costs off)
|
|
select b from gist_tbl where b <@ box(point(5,5), point(6,6))
|
|
order by point(5.2, 5.91) <-> b;
|
|
|
|
select b from gist_tbl where b <@ box(point(5,5), point(6,6))
|
|
order by point(5.2, 5.91) <-> b;
|
|
|
|
drop index gist_tbl_box_index;
|
|
|
|
-- Test that an index-only scan is not chosen, when the query involves the
|
|
-- circle column (the circle opclass does not support index-only scans).
|
|
create index gist_tbl_multi_index on gist_tbl using gist (p, c);
|
|
|
|
explain (costs off)
|
|
select p, c from gist_tbl
|
|
where p <@ box(point(5,5), point(6, 6));
|
|
|
|
-- execute the same
|
|
select b, p from gist_tbl
|
|
where b <@ box(point(4.5, 4.5), point(5.5, 5.5))
|
|
and p <@ box(point(5,5), point(6, 6));
|
|
|
|
drop index gist_tbl_multi_index;
|
|
|
|
-- Test that we don't try to return the value of a non-returnable
|
|
-- column in an index-only scan. (This isn't GIST-specific, but
|
|
-- it only applies to index AMs that can return some columns and not
|
|
-- others, so GIST with appropriate opclasses is a convenient test case.)
|
|
create index gist_tbl_multi_index on gist_tbl using gist (circle(p,1), p);
|
|
explain (verbose, costs off)
|
|
select circle(p,1) from gist_tbl
|
|
where p <@ box(point(5, 5), point(5.3, 5.3));
|
|
select circle(p,1) from gist_tbl
|
|
where p <@ box(point(5, 5), point(5.3, 5.3));
|
|
|
|
-- Similarly, test that index rechecks involving a non-returnable column
|
|
-- are done correctly.
|
|
explain (verbose, costs off)
|
|
select p from gist_tbl where circle(p,1) @> circle(point(0,0),0.95);
|
|
select p from gist_tbl where circle(p,1) @> circle(point(0,0),0.95);
|
|
|
|
-- This case isn't supported, but it should at least EXPLAIN correctly.
|
|
explain (verbose, costs off)
|
|
select p from gist_tbl order by circle(p,1) <-> point(0,0) limit 1;
|
|
select p from gist_tbl order by circle(p,1) <-> point(0,0) limit 1;
|
|
|
|
-- Clean up
|
|
reset enable_seqscan;
|
|
reset enable_bitmapscan;
|
|
reset enable_indexonlyscan;
|
|
|
|
drop table gist_tbl;
|