mirror of
https://github.com/postgres/postgres.git
synced 2025-09-11 00:12:06 +03:00
8cd190e13a
We were identifying the updatable generated columns of inheritance
children by transposing the calculation made for their parent.
However, there's nothing that says a traditional-inheritance child
can't have generated columns that aren't there in its parent, or that
have different dependencies than are in the parent's expression.
(At present it seems that we don't enforce that for partitioning
either, which is likely wrong to some degree or other; but the case
clearly needs to be handled with traditional inheritance.)
Hence, drop the very-klugy-anyway "extraUpdatedCols" RTE field
in favor of identifying which generated columns depend on updated
columns during executor startup. In HEAD we can remove
extraUpdatedCols altogether; in back branches, it's still there but
always empty. Another difference between the HEAD and back-branch
versions of this patch is that in HEAD we can add the new bitmap field
to ResultRelInfo, but that would cause an ABI break in back branches.
Like 4b3e37993, add a List field at the end of struct EState instead.
Back-patch to v13. The bogus calculation is also being made in v12,
but it doesn't have the same visible effect because we don't use it
to decide which generated columns to recalculate; as a consequence of
which the patch doesn't apply easily. I think that there might still
be a demonstrable bug associated with trigger firing conditions, but
that's such a weird corner-case usage that I'm content to leave it
unfixed in v12.
Amit Langote and Tom Lane
Discussion: https://postgr.es/m/CA+HiwqFshLKNvQUd1DgwJ-7tsTp=dwv7KZqXC4j2wYBV1aCDUA@mail.gmail.com
Discussion: https://postgr.es/m/2793383.1672944799@sss.pgh.pa.us
81 lines
2.5 KiB
C
81 lines
2.5 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* plancat.h
|
|
* prototypes for plancat.c.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2021, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/optimizer/plancat.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef PLANCAT_H
|
|
#define PLANCAT_H
|
|
|
|
#include "nodes/pathnodes.h"
|
|
#include "utils/relcache.h"
|
|
|
|
/* Hook for plugins to get control in get_relation_info() */
|
|
typedef void (*get_relation_info_hook_type) (PlannerInfo *root,
|
|
Oid relationObjectId,
|
|
bool inhparent,
|
|
RelOptInfo *rel);
|
|
extern PGDLLIMPORT get_relation_info_hook_type get_relation_info_hook;
|
|
|
|
|
|
extern void get_relation_info(PlannerInfo *root, Oid relationObjectId,
|
|
bool inhparent, RelOptInfo *rel);
|
|
|
|
extern List *infer_arbiter_indexes(PlannerInfo *root);
|
|
|
|
extern void estimate_rel_size(Relation rel, int32 *attr_widths,
|
|
BlockNumber *pages, double *tuples, double *allvisfrac);
|
|
|
|
extern int32 get_rel_data_width(Relation rel, int32 *attr_widths);
|
|
extern int32 get_relation_data_width(Oid relid, int32 *attr_widths);
|
|
|
|
extern bool relation_excluded_by_constraints(PlannerInfo *root,
|
|
RelOptInfo *rel, RangeTblEntry *rte);
|
|
|
|
extern List *build_physical_tlist(PlannerInfo *root, RelOptInfo *rel);
|
|
|
|
extern bool has_unique_index(RelOptInfo *rel, AttrNumber attno);
|
|
|
|
extern Selectivity restriction_selectivity(PlannerInfo *root,
|
|
Oid operatorid,
|
|
List *args,
|
|
Oid inputcollid,
|
|
int varRelid);
|
|
|
|
extern Selectivity join_selectivity(PlannerInfo *root,
|
|
Oid operatorid,
|
|
List *args,
|
|
Oid inputcollid,
|
|
JoinType jointype,
|
|
SpecialJoinInfo *sjinfo);
|
|
|
|
extern Selectivity function_selectivity(PlannerInfo *root,
|
|
Oid funcid,
|
|
List *args,
|
|
Oid inputcollid,
|
|
bool is_join,
|
|
int varRelid,
|
|
JoinType jointype,
|
|
SpecialJoinInfo *sjinfo);
|
|
|
|
extern void add_function_cost(PlannerInfo *root, Oid funcid, Node *node,
|
|
QualCost *cost);
|
|
|
|
extern double get_function_rows(PlannerInfo *root, Oid funcid, Node *node);
|
|
|
|
extern bool has_row_triggers(PlannerInfo *root, Index rti, CmdType event);
|
|
|
|
extern bool has_stored_generated_columns(PlannerInfo *root, Index rti);
|
|
|
|
extern Bitmapset *get_dependent_generated_columns(PlannerInfo *root, Index rti,
|
|
Bitmapset *target_cols);
|
|
|
|
#endif /* PLANCAT_H */
|