Andrew Dunstan 7ca548f23a Revert non-text output formats for pg_dumpall ...

This reverts the non-text (custom/directory/tar) output format support
for pg_dumpall added by 763aaa06f0 and its feature-specific follow-ups,
in line with Noah Misch's post-commit review which recommends reverting
and finishing the work through the commitfest.

Scope is deliberately minimal: only the feature itself is removed.
Independent improvements that merely touched the same files, or that were
committed alongside the feature but do not depend on its design, are
preserved.

Reverted (the feature):

  763aaa06f0  Add non-text output formats to pg_dumpall
  d6d9b96b40  Clean up nodes that are no longer of use in 007_pgdumpall.pl
  01c729e0c7  Fix casting away const-ness in pg_restore.c
  c7572cd48d  Improve writing map.dat preamble
  3c19983cc0  pg_restore: add --no-globals option to skip globals
  abff4492d0  Fix options listing of pg_restore --no-globals
  bb53b8d359  Fix small memory leak in get_dbname_oid_list_from_mfile()
  a793677e57  pg_restore: Remove dead code in restore_all_databases()
  a198c26ded  pg_dumpall: simplify coding of dropDBs()
  ec80215c03  pg_restore: Remove unnecessary strlen() calls in options parsing

Preserved (independent of the feature):

  b2898baaf7  the check_mut_excl_opts() helper in src/fe_utils/option_utils.c
               and its use in pg_dump
  7c8280eeb5  pg_dump's conflicting-option refactor (and tests 002/005)
  be0d0b457c  pg_dumpall's rejection of --clean together with --data-only
               (re-expressed directly, since pg_dumpall.c is otherwise
               returned to its pre-feature state)
  74b4438a70  the dangling-grantor-OID GRANT fix (back-patched through 16)
  273d26b75e, d4cb9c3776  independent pg_restore.sgml clarifications

Because the feature restructured pg_dumpall.c and pg_restore.c (pg_restore's
main() was split into restore_one_database() plus a dispatcher) and
interleaved its option checks with the conflicting-option refactor in the
same regions, the cosmetic check_mut_excl_opts() reflow of those two files'
option blocks is inseparable from the feature and comes out with it; the
behavior is unchanged.  The reusable helper and pg_dump's use of it are
unaffected.

Discussion: https://postgr.es/m/20260607000218.96.noahmisch@microsoft.com

2026-06-18 09:39:21 -04:00

..

src

Revert non-text output formats for pg_dumpall

2026-06-18 09:39:21 -04:00

KNOWN_BUGS

…

Makefile

Remove distprep

2023-11-06 15:18:04 +01:00

MISSING_FEATURES

…

TODO

…