Tom Lane
6d30fb1f75
Make SPI_fnumber() reject dropped columns.
...
There's basically no scenario where it's sensible for this to match
dropped columns, so put a test for dropped-ness into SPI_fnumber()
itself, and excise the test from the small number of callers that
were paying attention to the case. (Most weren't :-(.)
In passing, normalize tests at call sites: always reject attnum <= 0
if we're disallowing system columns. Previously there was a mixture
of "< 0" and "<= 0" tests. This makes no practical difference since
SPI_fnumber() never returns 0, but I'm feeling pedantic today.
Also, in the places that are actually live user-facing code and not
legacy cruft, distinguish "column not found" from "can't handle
system column".
Per discussion with Jim Nasby; thi supersedes his original patch
that just changed the behavior at one call site.
Discussion: <b2de8258-c4c0-1cb8-7b97-e8538e5c975c@BlueTreble.com >
2016-11-08 13:11:26 -05:00
..
2016-07-25 22:07:44 -04:00
2016-08-23 23:21:10 -04:00
2016-08-27 17:50:38 -04:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-10-30 12:27:41 -04:00
2016-08-27 17:50:38 -04:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-09-14 12:00:00 -05:00
2016-01-02 13:33:40 -05:00
2016-08-16 20:33:01 -04:00
2016-10-19 18:11:49 -04:00
2016-06-09 18:02:36 -04:00
2016-08-16 16:14:16 -04:00
2016-09-09 09:20:34 -04:00
2016-01-02 13:33:40 -05:00
2016-09-05 12:59:55 -04:00
2016-06-03 18:34:05 -04:00
2016-07-14 18:45:59 -04:00
2016-01-02 13:33:40 -05:00
2016-09-28 17:08:40 -04:00
2016-01-02 13:33:40 -05:00
2016-07-16 14:42:37 -04:00
2016-01-02 13:33:40 -05:00
2016-06-09 18:02:36 -04:00
2014-05-06 12:12:18 -04:00
2016-06-16 17:16:32 -04:00
2016-01-02 13:33:40 -05:00
2016-10-12 14:54:08 -04:00
2016-03-15 18:06:11 -04:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-06-09 18:02:36 -04:00
2016-08-15 13:42:51 -04:00
2016-10-13 00:25:48 -04:00
2016-01-22 11:53:06 -05:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-03-10 12:44:09 -05:00
2014-10-21 16:16:39 -04:00
2016-08-23 15:16:30 -04:00
2016-10-04 11:01:42 -04:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-08-23 16:25:35 -04:00
2016-09-02 13:49:59 +03:00
2016-09-03 14:18:55 -04:00
2016-04-13 07:54:45 -04:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-02-17 15:40:00 +05:30
2016-02-28 23:39:20 -05:00
2016-01-02 13:33:40 -05:00
2016-04-06 21:45:32 -04:00
2016-09-10 13:49:04 -04:00
2016-11-07 09:21:00 -05:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-01-02 13:33:40 -05:00
2016-06-09 18:02:36 -04:00
2016-08-07 18:52:02 -04:00
2016-01-02 13:33:40 -05:00
2016-08-17 18:33:01 -04:00
2016-01-05 13:02:43 -05:00
2016-10-23 15:01:24 -04:00
2016-01-02 13:33:40 -05:00
2016-11-04 10:49:50 -05:00
2016-08-07 18:52:02 -04:00
2016-01-02 13:33:40 -05:00
2016-08-16 20:33:01 -04:00
2016-01-02 13:33:40 -05:00
2016-06-27 20:47:32 +03:00
2016-06-27 20:47:32 +03:00
2016-08-15 13:42:51 -04:00
2016-03-02 17:37:54 -05:00
2016-06-09 18:02:36 -04:00
2016-10-30 17:35:42 -04:00
2016-10-30 15:24:40 -04:00
2016-08-16 14:52:29 -04:00
2016-06-27 20:47:32 +03:00
2016-11-08 13:11:26 -05:00
2016-04-07 18:44:18 +03:00
2016-04-08 12:04:15 +03:00
2016-08-23 10:30:52 -04:00
2016-06-09 18:02:36 -04:00
2016-10-14 16:28:34 -04:00
2016-02-03 14:29:53 -05:00
2016-09-25 15:40:57 -04:00
2016-01-02 13:33:40 -05:00
2016-03-15 18:06:11 -04:00
2016-10-18 12:24:46 -04:00
2016-08-27 17:50:38 -04:00