mirror of
				https://github.com/postgres/postgres.git
				synced 2025-10-28 11:55:03 +03:00 
			
		
		
		
	This commit adds a regression test to verify that pg_stat_statements correctly handles privileges, improving its test coverage. Author: Keisuke Kuroda Reviewed-by: Michael Paquier, Fujii Masao Discussion: https://postgr.es/m/2224ccf2e12c41ccb81702ef3303d5ac@nttcom.co.jp
		
			
				
	
	
		
			98 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			98 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
| --
 | |
| -- Only superusers and roles with privileges of the pg_read_all_stats role
 | |
| -- are allowed to see the SQL text and queryid of queries executed by
 | |
| -- other users. Other users can see the statistics.
 | |
| --
 | |
| SET pg_stat_statements.track_utility = FALSE;
 | |
| CREATE ROLE regress_stats_superuser SUPERUSER;
 | |
| CREATE ROLE regress_stats_user1;
 | |
| CREATE ROLE regress_stats_user2;
 | |
| GRANT pg_read_all_stats TO regress_stats_user2;
 | |
| SET ROLE regress_stats_superuser;
 | |
| SELECT pg_stat_statements_reset() IS NOT NULL AS t;
 | |
|  t 
 | |
| ---
 | |
|  t
 | |
| (1 row)
 | |
| 
 | |
| SELECT 1 AS "ONE";
 | |
|  ONE 
 | |
| -----
 | |
|    1
 | |
| (1 row)
 | |
| 
 | |
| SET ROLE regress_stats_user1;
 | |
| SELECT 1+1 AS "TWO";
 | |
|  TWO 
 | |
| -----
 | |
|    2
 | |
| (1 row)
 | |
| 
 | |
| --
 | |
| -- A superuser can read all columns of queries executed by others,
 | |
| -- including query text and queryid.
 | |
| --
 | |
| SET ROLE regress_stats_superuser;
 | |
| SELECT r.rolname, ss.queryid <> 0 AS queryid_bool, ss.query, ss.calls, ss.rows
 | |
|   FROM pg_stat_statements ss JOIN pg_roles r ON ss.userid = r.oid
 | |
|   ORDER BY r.rolname, ss.query COLLATE "C", ss.calls, ss.rows;
 | |
|          rolname         | queryid_bool |                       query                        | calls | rows 
 | |
| -------------------------+--------------+----------------------------------------------------+-------+------
 | |
|  regress_stats_superuser | t            | SELECT $1 AS "ONE"                                 |     1 |    1
 | |
|  regress_stats_superuser | t            | SELECT pg_stat_statements_reset() IS NOT NULL AS t |     1 |    1
 | |
|  regress_stats_user1     | t            | SELECT $1+$2 AS "TWO"                              |     1 |    1
 | |
| (3 rows)
 | |
| 
 | |
| --
 | |
| -- regress_stats_user1 has no privileges to read the query text or
 | |
| -- queryid of queries executed by others but can see statistics
 | |
| -- like calls and rows.
 | |
| --
 | |
| SET ROLE regress_stats_user1;
 | |
| SELECT r.rolname, ss.queryid <> 0 AS queryid_bool, ss.query, ss.calls, ss.rows
 | |
|   FROM pg_stat_statements ss JOIN pg_roles r ON ss.userid = r.oid
 | |
|   ORDER BY r.rolname, ss.query COLLATE "C", ss.calls, ss.rows;
 | |
|          rolname         | queryid_bool |          query           | calls | rows 
 | |
| -------------------------+--------------+--------------------------+-------+------
 | |
|  regress_stats_superuser |              | <insufficient privilege> |     1 |    1
 | |
|  regress_stats_superuser |              | <insufficient privilege> |     1 |    1
 | |
|  regress_stats_superuser |              | <insufficient privilege> |     1 |    3
 | |
|  regress_stats_user1     | t            | SELECT $1+$2 AS "TWO"    |     1 |    1
 | |
| (4 rows)
 | |
| 
 | |
| --
 | |
| -- regress_stats_user2, with pg_read_all_stats role privileges, can
 | |
| -- read all columns, including query text and queryid, of queries
 | |
| -- executed by others.
 | |
| --
 | |
| SET ROLE regress_stats_user2;
 | |
| SELECT r.rolname, ss.queryid <> 0 AS queryid_bool, ss.query, ss.calls, ss.rows
 | |
|   FROM pg_stat_statements ss JOIN pg_roles r ON ss.userid = r.oid
 | |
|   ORDER BY r.rolname, ss.query COLLATE "C", ss.calls, ss.rows;
 | |
|          rolname         | queryid_bool |                                      query                                      | calls | rows 
 | |
| -------------------------+--------------+---------------------------------------------------------------------------------+-------+------
 | |
|  regress_stats_superuser | t            | SELECT $1 AS "ONE"                                                              |     1 |    1
 | |
|  regress_stats_superuser | t            | SELECT pg_stat_statements_reset() IS NOT NULL AS t                              |     1 |    1
 | |
|  regress_stats_superuser | t            | SELECT r.rolname, ss.queryid <> $1 AS queryid_bool, ss.query, ss.calls, ss.rows+|     1 |    3
 | |
|                          |              |   FROM pg_stat_statements ss JOIN pg_roles r ON ss.userid = r.oid              +|       | 
 | |
|                          |              |   ORDER BY r.rolname, ss.query COLLATE "C", ss.calls, ss.rows                   |       | 
 | |
|  regress_stats_user1     | t            | SELECT $1+$2 AS "TWO"                                                           |     1 |    1
 | |
|  regress_stats_user1     | t            | SELECT r.rolname, ss.queryid <> $1 AS queryid_bool, ss.query, ss.calls, ss.rows+|     1 |    4
 | |
|                          |              |   FROM pg_stat_statements ss JOIN pg_roles r ON ss.userid = r.oid              +|       | 
 | |
|                          |              |   ORDER BY r.rolname, ss.query COLLATE "C", ss.calls, ss.rows                   |       | 
 | |
| (5 rows)
 | |
| 
 | |
| --
 | |
| -- cleanup
 | |
| --
 | |
| RESET ROLE;
 | |
| DROP ROLE regress_stats_superuser;
 | |
| DROP ROLE regress_stats_user1;
 | |
| DROP ROLE regress_stats_user2;
 | |
| SELECT pg_stat_statements_reset() IS NOT NULL AS t;
 | |
|  t 
 | |
| ---
 | |
|  t
 | |
| (1 row)
 | |
| 
 |