mirror of
				https://github.com/postgres/postgres.git
				synced 2025-11-03 09:13:20 +03:00 
			
		
		
		
	This commit introduces a new column mem_exceeded_count to the pg_stat_replication_slots view. This counter tracks how often the memory used by logical decoding exceeds the logical_decoding_work_mem limit. The new statistic helps users determine whether exceeding the logical_decoding_work_mem limit is a rare occurrences or a frequent issue, information that wasn't available through existing statistics. Bumps catversion. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Reviewed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://postgr.es/m/978D21E8-9D3B-40EA-A4B1-F87BABE7868C@yesql.se
		
			
				
	
	
		
			78 lines
		
	
	
		
			4.3 KiB
		
	
	
	
		
			PL/PgSQL
		
	
	
	
	
	
			
		
		
	
	
			78 lines
		
	
	
		
			4.3 KiB
		
	
	
	
		
			PL/PgSQL
		
	
	
	
	
	
-- predictability
 | 
						|
SET synchronous_commit = on;
 | 
						|
 | 
						|
SELECT 'init' FROM
 | 
						|
    pg_create_logical_replication_slot('regression_slot_stats1', 'test_decoding') s1,
 | 
						|
    pg_create_logical_replication_slot('regression_slot_stats2', 'test_decoding') s2,
 | 
						|
    pg_create_logical_replication_slot('regression_slot_stats3', 'test_decoding') s3;
 | 
						|
 | 
						|
CREATE TABLE stats_test(data text);
 | 
						|
 | 
						|
-- non-spilled xact
 | 
						|
SET logical_decoding_work_mem to '64MB';
 | 
						|
INSERT INTO stats_test values(1);
 | 
						|
SELECT count(*) FROM pg_logical_slot_get_changes('regression_slot_stats1', NULL, NULL, 'skip-empty-xacts', '1');
 | 
						|
SELECT count(*) FROM pg_logical_slot_get_changes('regression_slot_stats2', NULL, NULL, 'skip-empty-xacts', '1');
 | 
						|
SELECT count(*) FROM pg_logical_slot_get_changes('regression_slot_stats3', NULL, NULL, 'skip-empty-xacts', '1');
 | 
						|
SELECT pg_stat_force_next_flush();
 | 
						|
SELECT slot_name, spill_txns = 0 AS spill_txns, spill_count = 0 AS spill_count, total_txns > 0 AS total_txns, total_bytes > 0 AS total_bytes, mem_exceeded_count = 0 AS mem_exceeded_count FROM pg_stat_replication_slots ORDER BY slot_name;
 | 
						|
RESET logical_decoding_work_mem;
 | 
						|
 | 
						|
-- reset stats for one slot, others should be unaffected
 | 
						|
SELECT pg_stat_reset_replication_slot('regression_slot_stats1');
 | 
						|
SELECT slot_name, spill_txns = 0 AS spill_txns, spill_count = 0 AS spill_count, total_txns > 0 AS total_txns, total_bytes > 0 AS total_bytes, mem_exceeded_count = 0 AS mem_exceeded_count FROM pg_stat_replication_slots ORDER BY slot_name;
 | 
						|
 | 
						|
-- reset stats for all slots
 | 
						|
SELECT pg_stat_reset_replication_slot(NULL);
 | 
						|
SELECT slot_name, spill_txns = 0 AS spill_txns, spill_count = 0 AS spill_count, total_txns > 0 AS total_txns, total_bytes > 0 AS total_bytes, mem_exceeded_count = 0 AS mem_exceeded_count FROM pg_stat_replication_slots ORDER BY slot_name;
 | 
						|
 | 
						|
-- verify accessing/resetting stats for non-existent slot does something reasonable
 | 
						|
SELECT * FROM pg_stat_get_replication_slot('do-not-exist');
 | 
						|
SELECT pg_stat_reset_replication_slot('do-not-exist');
 | 
						|
SELECT * FROM pg_stat_get_replication_slot('do-not-exist');
 | 
						|
 | 
						|
-- spilling the xact
 | 
						|
BEGIN;
 | 
						|
INSERT INTO stats_test SELECT 'serialize-topbig--1:'||g.i FROM generate_series(1, 5000) g(i);
 | 
						|
COMMIT;
 | 
						|
SELECT count(*) FROM pg_logical_slot_peek_changes('regression_slot_stats1', NULL, NULL, 'skip-empty-xacts', '1');
 | 
						|
 | 
						|
-- Check stats. We can't test the exact stats count as that can vary if any
 | 
						|
-- background transaction (say by autovacuum) happens in parallel to the main
 | 
						|
-- transaction.
 | 
						|
SELECT pg_stat_force_next_flush();
 | 
						|
SELECT slot_name, spill_txns > 0 AS spill_txns, spill_count > 0 AS spill_count, mem_exceeded_count > 0 AS mem_exceeded_count FROM pg_stat_replication_slots;
 | 
						|
 | 
						|
-- Ensure stats can be repeatedly accessed using the same stats snapshot. See
 | 
						|
-- https://postgr.es/m/20210317230447.c7uc4g3vbs4wi32i%40alap3.anarazel.de
 | 
						|
BEGIN;
 | 
						|
SELECT slot_name FROM pg_stat_replication_slots;
 | 
						|
SELECT slot_name FROM pg_stat_replication_slots;
 | 
						|
COMMIT;
 | 
						|
 | 
						|
 | 
						|
SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot_stats4_twophase', 'test_decoding', false, true) s4;
 | 
						|
 | 
						|
-- The INSERT changes are large enough to be spilled but will not be, because
 | 
						|
-- the transaction is aborted. The logical decoding skips collecting further
 | 
						|
-- changes too. The transaction is prepared to make sure the decoding processes
 | 
						|
-- the aborted transaction.
 | 
						|
BEGIN;
 | 
						|
INSERT INTO stats_test SELECT 'serialize-toobig--1:'||g.i FROM generate_series(1, 5000) g(i);
 | 
						|
PREPARE TRANSACTION 'test1_abort';
 | 
						|
ROLLBACK PREPARED 'test1_abort';
 | 
						|
SELECT count(*) FROM pg_logical_slot_get_changes('regression_slot_stats4_twophase', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1');
 | 
						|
 | 
						|
-- Verify that the decoding doesn't spill already-aborted transaction's changes.
 | 
						|
-- Given that there is no concurrent activities that are capturable by logical decoding,
 | 
						|
-- mem_exceeded_count should theoretically be 1 but we check if >0 here since it's
 | 
						|
-- more flexible for potential future changes and adequate for the testing purpose.
 | 
						|
SELECT pg_stat_force_next_flush();
 | 
						|
SELECT slot_name, spill_txns, spill_count, mem_exceeded_count > 0 as mem_exceeded_count FROM pg_stat_replication_slots WHERE slot_name = 'regression_slot_stats4_twophase';
 | 
						|
 | 
						|
DROP TABLE stats_test;
 | 
						|
SELECT pg_drop_replication_slot('regression_slot_stats1'),
 | 
						|
    pg_drop_replication_slot('regression_slot_stats2'),
 | 
						|
    pg_drop_replication_slot('regression_slot_stats3'),
 | 
						|
    pg_drop_replication_slot('regression_slot_stats4_twophase');
 |