mirror of
https://github.com/postgres/postgres.git
synced 2025-05-26 18:17:33 +03:00
41c6a5bec2
COMMIT/ROLLBACK necessarily destroys all snapshots within the session. The original implementation of intra-procedure transactions just cavalierly did that, ignoring the fact that this left us executing in a rather different environment than normal. In particular, it turns out that handling of toasted datums depends rather critically on there being an outer ActiveSnapshot: otherwise, when SPI or the core executor pop whatever snapshot they used and return, it's unsafe to dereference any toasted datums that may appear in the query result. It's possible to demonstrate "no known snapshots" and "missing chunk number N for toast value" errors as a result of this oversight. Historically this outer snapshot has been held by the Portal code, and that seems like a good plan to preserve. So add infrastructure to pquery.c to allow re-establishing the Portal-owned snapshot if it's not there anymore, and add enough bookkeeping support that we can tell whether it is or not. We can't, however, just re-establish the Portal snapshot as part of COMMIT/ROLLBACK. As in normal transaction start, acquiring the first snapshot should wait until after SET and LOCK commands. Hence, teach spi.c about doing this at the right time. (Note that this patch doesn't fix the problem for any PLs that try to run intra-procedure transactions without using SPI to execute SQL commands.) This makes SPI's no_snapshots parameter rather a misnomer, so in HEAD, rename that to allow_nonatomic. replication/logical/worker.c also needs some fixes, because it wasn't careful to hold a snapshot open around AFTER trigger execution. That code doesn't use a Portal, which I suspect someday we're gonna have to fix. But for now, just rearrange the order of operations. This includes back-patching the recent addition of finish_estate() to centralize the cleanup logic there. This also back-patches commit 2ecfeda3e into v13, to improve the test coverage for worker.c (it was that test that exposed that worker.c's snapshot management is wrong). Per bug #15990 from Andreas Wicht. Back-patch to v11 where intra-procedure COMMIT was added. Discussion: https://postgr.es/m/15990-eee2ac466b11293d@postgresql.org
52 lines
1.3 KiB
C
52 lines
1.3 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* pquery.h
|
|
* prototypes for pquery.c.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/tcop/pquery.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef PQUERY_H
|
|
#define PQUERY_H
|
|
|
|
#include "nodes/parsenodes.h"
|
|
#include "utils/portal.h"
|
|
|
|
struct PlannedStmt; /* avoid including plannodes.h here */
|
|
|
|
|
|
extern PGDLLIMPORT Portal ActivePortal;
|
|
|
|
|
|
extern PortalStrategy ChoosePortalStrategy(List *stmts);
|
|
|
|
extern List *FetchPortalTargetList(Portal portal);
|
|
|
|
extern List *FetchStatementTargetList(Node *stmt);
|
|
|
|
extern void PortalStart(Portal portal, ParamListInfo params,
|
|
int eflags, Snapshot snapshot);
|
|
|
|
extern void PortalSetResultFormat(Portal portal, int nFormats,
|
|
int16 *formats);
|
|
|
|
extern bool PortalRun(Portal portal, long count, bool isTopLevel,
|
|
bool run_once, DestReceiver *dest, DestReceiver *altdest,
|
|
char *completionTag);
|
|
|
|
extern uint64 PortalRunFetch(Portal portal,
|
|
FetchDirection fdirection,
|
|
long count,
|
|
DestReceiver *dest);
|
|
|
|
extern bool PlannedStmtRequiresSnapshot(struct PlannedStmt *pstmt);
|
|
|
|
extern void EnsurePortalSnapshotExists(void);
|
|
|
|
#endif /* PQUERY_H */
|