mirror of
https://github.com/postgres/postgres.git
synced 2025-05-02 11:44:50 +03:00
31b29b1b30
Commits 742869946 et al turn out to be a couple bricks shy of a load.
We were dumping the stored values of GUC_LIST_QUOTE variables as they
appear in proconfig or setconfig catalog columns. However, although that
quoting rule looks a lot like SQL-identifier double quotes, there are two
critical differences: empty strings ("") are legal, and depending on which
variable you're considering, values longer than NAMEDATALEN might be valid
too. So the current technique fails altogether on empty-string list
entries (as reported by Steven Winfield in bug #15248) and it also risks
truncating file pathnames during dump/reload of GUC values that are lists
of pathnames.
To fix, split the stored value without any downcasing or truncation,
and then emit each element as a SQL string literal.
This is a tad annoying, because we now have three copies of the
comma-separated-string splitting logic in varlena.c as well as a fourth
one in dumputils.c. (Not to mention the randomly-different-from-those
splitting logic in libpq...) I looked at unifying these, but it would
be rather a mess unless we're willing to tweak the API definitions of
SplitIdentifierString, SplitDirectoriesString, or both. That might be
worth doing in future; but it seems pretty unsafe for a back-patched
bug fix, so for now accept the duplication.
Back-patch to all supported branches, as the previous fix was.
Discussion: https://postgr.es/m/7585.1529435872@sss.pgh.pa.us
40 lines
1.4 KiB
C
40 lines
1.4 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* varlena.h
|
|
* Functions for the variable-length built-in types.
|
|
*
|
|
* Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/utils/varlena.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef VARLENA_H
|
|
#define VARLENA_H
|
|
|
|
#include "nodes/pg_list.h"
|
|
#include "utils/sortsupport.h"
|
|
|
|
extern int varstr_cmp(char *arg1, int len1, char *arg2, int len2, Oid collid);
|
|
extern void varstr_sortsupport(SortSupport ssup, Oid collid, bool bpchar);
|
|
extern int varstr_levenshtein(const char *source, int slen,
|
|
const char *target, int tlen,
|
|
int ins_c, int del_c, int sub_c,
|
|
bool trusted);
|
|
extern int varstr_levenshtein_less_equal(const char *source, int slen,
|
|
const char *target, int tlen,
|
|
int ins_c, int del_c, int sub_c,
|
|
int max_d, bool trusted);
|
|
extern List *textToQualifiedNameList(text *textval);
|
|
extern bool SplitIdentifierString(char *rawstring, char separator,
|
|
List **namelist);
|
|
extern bool SplitDirectoriesString(char *rawstring, char separator,
|
|
List **namelist);
|
|
extern bool SplitGUCList(char *rawstring, char separator,
|
|
List **namelist);
|
|
extern text *replace_text_regexp(text *src_text, void *regexp,
|
|
text *replace_text, bool glob);
|
|
|
|
#endif
|