mirror of
https://github.com/postgres/postgres.git
synced 2025-05-28 05:21:27 +03:00
2311f193ea
plpython.h included plpy_util.h, simply on the grounds that "it's easier to just include it everywhere". However, plpy_util.h must include plpython.h, or it won't pass headerscheck. While the resulting circularity doesn't have any immediate bad effect, it's poor design. We have seen serious messes arise in the past from overly-broad inclusion footprints created by such circularities, so let's establish a project policy against it. To fix, just replace *.c files' inclusions of plpython.h with plpy_util.h. They'll pull in plpython.h indirectly; indeed, almost all have already done so via inclusions of other plpy_xxx.h headers. (Any extensions using plpython.h can do likewise without breaking the compatibility of their code with prior Postgres versions.) Reported-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Discussion: https://postgr.es/m/aAxQ6fcY5QQV1lo3@ip-10-97-1-34.eu-west-3.compute.internal
46 lines
1.3 KiB
C
46 lines
1.3 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* plpython.h - Python as a procedural language for PostgreSQL
|
|
*
|
|
* Note: this file is #include'd by each of the sub-module header files
|
|
* (plpy_elog.h, etc). It's therefore unnecessary for any plpython *.c
|
|
* files to include it directly.
|
|
*
|
|
* Portions Copyright (c) 1996-2025, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/pl/plpython/plpython.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef PLPYTHON_H
|
|
#define PLPYTHON_H
|
|
|
|
/* postgres.h needs to be included before Python.h, as usual */
|
|
#if !defined(POSTGRES_H)
|
|
#error postgres.h must be included before plpython.h
|
|
#elif defined(Py_PYTHON_H)
|
|
#error Python.h must be included via plpython.h
|
|
#endif
|
|
|
|
/*
|
|
* Enable Python Limited API
|
|
*
|
|
* XXX currently not enabled on MSVC because of build failures
|
|
*/
|
|
#if !defined(_MSC_VER)
|
|
#define Py_LIMITED_API 0x03020000
|
|
#endif
|
|
|
|
/*
|
|
* Pull in Python headers via a wrapper header, to control the scope of
|
|
* the system_header pragma therein.
|
|
*/
|
|
#include "plpython_system.h"
|
|
|
|
/* define our text domain for translations */
|
|
#undef TEXTDOMAIN
|
|
#define TEXTDOMAIN PG_TEXTDOMAIN("plpython")
|
|
|
|
#endif /* PLPYTHON_H */
|