mirror of
https://github.com/postgres/postgres.git
synced 2025-10-19 15:49:24 +03:00
208927e656
pg_prewarm() currently checks for SELECT privileges on the target relation. However, indexes do not have access rights of their own, so a role may be denied permission to prewarm an index despite having the SELECT privilege on its parent table. This commit fixes this by locking the parent table before the index (to avoid deadlocks) and checking for SELECT on the parent table. Note that the code is largely borrowed from amcheck_lock_relation_and_check(). An obvious downside of this change is the extra AccessShareLock on the parent table during prewarming, but that isn't expected to cause too much trouble in practice. Author: Ayush Vatsa <ayushvatsa1810@gmail.com> Co-authored-by: Nathan Bossart <nathandbossart@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Jeff Davis <pgsql@j-davis.com> Discussion: https://postgr.es/m/CACX%2BKaMz2ZoOojh0nQ6QNBYx8Ak1Dkoko%3DD4FSb80BYW%2Bo8CHQ%40mail.gmail.com Backpatch-through: 13
92 lines
2.9 KiB
Perl
92 lines
2.9 KiB
Perl
|
|
# Copyright (c) 2021-2025, PostgreSQL Global Development Group
|
|
|
|
use strict;
|
|
use warnings FATAL => 'all';
|
|
|
|
use PostgreSQL::Test::Cluster;
|
|
use PostgreSQL::Test::Utils;
|
|
use Test::More;
|
|
|
|
|
|
my $node = PostgreSQL::Test::Cluster->new('main');
|
|
|
|
$node->init;
|
|
$node->append_conf(
|
|
'postgresql.conf',
|
|
qq{shared_preload_libraries = 'pg_prewarm'
|
|
pg_prewarm.autoprewarm = true
|
|
pg_prewarm.autoprewarm_interval = 0});
|
|
$node->start;
|
|
|
|
# setup
|
|
$node->safe_psql("postgres",
|
|
"CREATE EXTENSION pg_prewarm;\n"
|
|
. "CREATE TABLE test(c1 int);\n"
|
|
. "INSERT INTO test SELECT generate_series(1, 100);\n"
|
|
. "CREATE INDEX test_idx ON test(c1);\n"
|
|
. "CREATE ROLE test_user LOGIN;");
|
|
|
|
# test read mode
|
|
my $result =
|
|
$node->safe_psql("postgres", "SELECT pg_prewarm('test', 'read');");
|
|
like($result, qr/^[1-9][0-9]*$/, 'read mode succeeded');
|
|
|
|
# test buffer_mode
|
|
$result =
|
|
$node->safe_psql("postgres", "SELECT pg_prewarm('test', 'buffer');");
|
|
like($result, qr/^[1-9][0-9]*$/, 'buffer mode succeeded');
|
|
|
|
# prefetch mode might or might not be available
|
|
my ($cmdret, $stdout, $stderr) =
|
|
$node->psql("postgres", "SELECT pg_prewarm('test', 'prefetch');");
|
|
ok( ( $stdout =~ qr/^[1-9][0-9]*$/
|
|
or $stderr =~ qr/prefetch is not supported by this build/),
|
|
'prefetch mode succeeded');
|
|
|
|
# test_user should be unable to prewarm table/index without privileges
|
|
($cmdret, $stdout, $stderr) =
|
|
$node->psql(
|
|
"postgres", "SELECT pg_prewarm('test');",
|
|
extra_params => [ '--username' => 'test_user' ]);
|
|
ok($stderr =~ /permission denied for table test/, 'pg_prewarm failed as expected');
|
|
($cmdret, $stdout, $stderr) =
|
|
$node->psql(
|
|
"postgres", "SELECT pg_prewarm('test_idx');",
|
|
extra_params => [ '--username' => 'test_user' ]);
|
|
ok($stderr =~ /permission denied for index test_idx/, 'pg_prewarm failed as expected');
|
|
|
|
# test_user should be able to prewarm table/index with privileges
|
|
$node->safe_psql("postgres", "GRANT SELECT ON test TO test_user;");
|
|
$result =
|
|
$node->safe_psql(
|
|
"postgres", "SELECT pg_prewarm('test');",
|
|
extra_params => [ '--username' => 'test_user' ]);
|
|
like($result, qr/^[1-9][0-9]*$/, 'pg_prewarm succeeded as expected');
|
|
$result =
|
|
$node->safe_psql(
|
|
"postgres", "SELECT pg_prewarm('test_idx');",
|
|
extra_params => [ '--username' => 'test_user' ]);
|
|
like($result, qr/^[1-9][0-9]*$/, 'pg_prewarm succeeded as expected');
|
|
|
|
# test autoprewarm_dump_now()
|
|
$result = $node->safe_psql("postgres", "SELECT autoprewarm_dump_now();");
|
|
like($result, qr/^[1-9][0-9]*$/, 'autoprewarm_dump_now succeeded');
|
|
|
|
# restart, to verify that auto prewarm actually works
|
|
$node->restart;
|
|
|
|
$node->wait_for_log(
|
|
"autoprewarm successfully prewarmed [1-9][0-9]* of [0-9]+ previously-loaded blocks"
|
|
);
|
|
|
|
$node->stop;
|
|
|
|
# control file should indicate normal shut down
|
|
command_like(
|
|
[ 'pg_controldata', $node->data_dir() ],
|
|
qr/Database cluster state:\s*shut down/,
|
|
'cluster shut down normally');
|
|
|
|
done_testing();
|