Tomas Vondra 1e468ea4ea Lock table in DROP STATISTICS ...

The DROP STATISTICS code failed to properly lock the table, leading to

  ERROR:  tuple concurrently deleted

when executed concurrently with ANALYZE.

Fixed by modifying RemoveStatisticsById() to acquire the same lock as
ANALYZE. This function is called only by DROP STATISTICS, as ANALYZE
calls RemoveStatisticsDataById() directly.

Reported by Justin Pryzby, fix by me. Backpatch through 12. The code was
like this since it was introduced in 10, but older releases are EOL.

Reported-by: Justin Pryzby
Reviewed-by: Tom Lane
Backpatch-through: 12

Discussion: https://postgr.es/m/ZUuk-8CfbYeq6g_u@pryzbyj2023

2023-11-19 21:04:39 +01:00

..

aggregatecmds.c

Update copyrights for 2020

2020-01-01 12:21:45 -05:00

alter.c

Initial pgindent and pgperltidy run for v13.

2020-05-14 13:06:50 -04:00

amcmds.c

Add missing invocations to object access hooks

2020-05-23 14:03:04 +09:00

analyze.c

Fix briefly showing old progress stats for ANALYZE on inherited tables.

2023-09-30 17:07:41 +03:00

async.c

Send NOTIFY signals during CommitTransaction.

2021-09-14 17:18:25 -04:00

cluster.c

Make relation-enumerating operations be security-restricted operations.

2022-05-09 08:35:12 -07:00

collationcmds.c

Disallow creating an ICU collation if the DB encoding won't support it.

2021-09-03 16:38:55 -04:00

comment.c

Update copyrights for 2020

2020-01-01 12:21:45 -05:00

constraint.c

Fix bogus CALLED_AS_TRIGGER() defenses.

2020-04-03 11:24:56 -04:00

conversioncmds.c

Remove utils/acl.h from catalog/objectaddress.h

2020-03-10 10:27:00 +01:00

copy.c

Ensure we preprocess expressions before checking their volatility.

2023-11-16 10:05:14 -05:00

createas.c

In extensions, don't replace objects not belonging to the extension.

2022-08-08 11:12:31 -04:00

dbcommands.c

Handle DROP DATABASE getting interrupted

2023-07-13 13:03:34 -07:00

define.c

Update copyrights for 2020

2020-01-01 12:21:45 -05:00

discard.c

Update copyrights for 2020

2020-01-01 12:21:45 -05:00

dropcmds.c

Remove utils/acl.h from catalog/objectaddress.h

2020-03-10 10:27:00 +01:00

event_trigger.c

Fix use-after-free bug with event triggers in an extension script

2020-09-15 21:03:14 -03:00

explain.c

Fix index-only scan plans, take 2.

2022-01-03 15:42:27 -05:00

extension.c

Reject substituting extension schemas or owners matching ["$'\].

2023-08-07 06:06:00 -07:00

foreigncmds.c

In extensions, don't replace objects not belonging to the extension.

2022-08-08 11:12:31 -04:00

functioncmds.c

Fix breakage in AlterFunction().

2022-04-19 23:03:59 -04:00

indexcmds.c

Ensure we preprocess expressions before checking their volatility.

2023-11-16 10:05:14 -05:00

lockcmds.c

Revert "Accept relations of any kind in LOCK TABLE".

2020-11-06 16:17:56 -05:00

Makefile

Revert 0f5ca02f53

2020-04-08 11:37:27 +03:00

matview.c

In REFRESH MATERIALIZED VIEW, set user ID before running user code.

2022-05-09 08:35:12 -07:00

opclasscmds.c

Fix DDL deparse of CREATE OPERATOR CLASS

2022-05-20 18:52:55 +02:00

operatorcmds.c

Prevent ALTER TYPE/DOMAIN/OPERATOR from changing extension membership.

2021-08-17 14:29:22 -04:00

policy.c

Remove unnecessary failure cases in RemoveRoleFromObjectPolicy().

2021-06-25 13:59:38 -04:00

portalcmds.c

Fix some anomalies with NO SCROLL cursors.

2021-09-10 13:18:32 -04:00

prepare.c

Fix plancache refcount leak after error in ExecuteQuery.

2021-06-16 19:30:17 -04:00

proclang.c

Remove the "opaque" pseudo-type and associated compatibility hacks.

2020-03-05 15:48:56 -05:00

publicationcmds.c

Invalidate all partitions for a partitioned table in publication.

2021-09-22 08:24:20 +05:30

schemacmds.c

Replace last PushOverrideSearchPath() call with set_config_option().

2023-05-08 06:14:12 -07:00

seclabel.c

Check criticalSharedRelcachesBuilt in GetSharedSecurityLabel().

2021-10-14 12:24:47 -07:00

sequence.c

In extensions, don't replace objects not belonging to the extension.

2022-08-08 11:12:31 -04:00

statscmds.c

Lock table in DROP STATISTICS

2023-11-19 21:04:39 +01:00

subscriptioncmds.c

Fix the errhint message and docs for drop subscription failure.

2023-06-21 10:22:07 +05:30

tablecmds.c

Ensure we preprocess expressions before checking their volatility.

2023-11-16 10:05:14 -05:00

tablespace.c

Fix replay of create database records on standby

2022-07-28 08:26:05 +02:00

trigger.c

Fix oversight in handling of modifiedCols since f24523672d

2023-07-02 22:23:20 +02:00

tsearchcmds.c

Preserve integer and float values accurately in (de)serialize_deflist.

2020-03-10 12:30:02 -04:00

typecmds.c

Prevent ALTER TYPE/DOMAIN/OPERATOR from changing extension membership.

2021-08-17 14:29:22 -04:00

user.c

Change some errdetail() to errdetail_internal()

2022-09-28 17:14:53 +02:00

vacuum.c

Handle DROP DATABASE getting interrupted

2023-07-13 13:03:34 -07:00

variable.c

Fix some inappropriately-disallowed uses of ALTER ROLE/DATABASE SET.

2021-04-13 15:10:18 -04:00

view.c

In extensions, don't replace objects not belonging to the extension.

2022-08-08 11:12:31 -04:00