mirror of
https://github.com/postgres/postgres.git
synced 2025-11-06 07:49:08 +03:00
0b33790421
Revert the matview-related changes in explain.c's API, as per recent complaint from Robert Haas. The reason for these appears to have been principally some ill-considered choices around having intorel_startup do what ought to be parse-time checking, plus a poor arrangement for passing it the view parsetree it needs to store into pg_rewrite when creating a materialized view. Do the latter by having parse analysis stick a copy into the IntoClause, instead of doing it at runtime. (On the whole, I seriously question the choice to represent CREATE MATERIALIZED VIEW as a variant of SELECT INTO/CREATE TABLE AS, because that means injecting even more complexity into what was already a horrid legacy kluge. However, I didn't go so far as to rethink that choice ... yet.) I also moved several error checks into matview parse analysis, and made the check for external Params in a matview more accurate. In passing, clean things up a bit more around interpretOidsOption(), and fix things so that we can use that to force no-oids for views, sequences, etc, thereby eliminating the need to cons up "oids = false" options when creating them. catversion bump due to change in IntoClause. (I wonder though if we really need readfuncs/outfuncs support for IntoClause anymore.)
26 lines
832 B
C
26 lines
832 B
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* parse_param.h
|
|
* handle parameters in parser
|
|
*
|
|
* Portions Copyright (c) 1996-2013, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/parser/parse_param.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef PARSE_PARAM_H
|
|
#define PARSE_PARAM_H
|
|
|
|
#include "parser/parse_node.h"
|
|
|
|
extern void parse_fixed_parameters(ParseState *pstate,
|
|
Oid *paramTypes, int numParams);
|
|
extern void parse_variable_parameters(ParseState *pstate,
|
|
Oid **paramTypes, int *numParams);
|
|
extern void check_variable_parameters(ParseState *pstate, Query *query);
|
|
extern bool query_contains_extern_params(Query *query);
|
|
|
|
#endif /* PARSE_PARAM_H */
|