Tom Lane 41b45576d5 Remove useless pfree()s at the ends of various ValuePerCall SRFs. ...

We don't need to manually clean up allocations in a SRF's
multi_call_memory_ctx, because the SRF_RETURN_DONE infrastructure
takes care of that (and also ensures that it will happen even if the
function never gets a final call, which simple manual cleanup cannot
do).

Hence, the code removed by this patch is a waste of code and cycles.
Worse, it gives the impression that cleaning up manually is a thing,
which can lead to more serious errors such as those fixed in
commits 085b6b667 and b4570d33a.  So we should get rid of it.

These are not quite actual bugs though, so I couldn't muster the
enthusiasm to back-patch.  Fix in HEAD only.

Justin Pryzby

Discussion: https://postgr.es/m/20200308173103.GC1357@telsasoft.com

2020-03-16 21:36:53 -04:00

..

expected

Add an explicit test to catch changes in checksumming calculations.

2020-03-08 15:09:14 -04:00

sql

Add an explicit test to catch changes in checksumming calculations.

2020-03-08 15:09:14 -04:00

.gitignore

pageinspect: Add tests

2016-11-01 14:02:16 -04:00

brinfuncs.c

Remove excess parens in ereport() calls

2020-01-30 13:32:04 -03:00

btreefuncs.c

Remove useless pfree()s at the ends of various ValuePerCall SRFs.

2020-03-16 21:36:53 -04:00

fsmfuncs.c

Remove excess parens in ereport() calls

2020-01-30 13:32:04 -03:00

ginfuncs.c

Remove useless pfree()s at the ends of various ValuePerCall SRFs.

2020-03-16 21:36:53 -04:00

hashfuncs.c

Remove useless pfree()s at the ends of various ValuePerCall SRFs.

2020-03-16 21:36:53 -04:00

heapfuncs.c

Introduce macros for typalign and typstorage constants.

2020-03-04 10:34:25 -05:00

Makefile

Add an explicit test to catch changes in checksumming calculations.

2020-03-08 15:09:14 -04:00

pageinspect--1.0--1.1.sql

Fix typos in some error messages thrown by extension scripts when fed to psql.

2014-08-25 18:30:37 +02:00

pageinspect--1.1--1.2.sql

Fix typos in some error messages thrown by extension scripts when fed to psql.

2014-08-25 18:30:37 +02:00

pageinspect--1.2--1.3.sql

pageinspect/BRIN: minor tweaks

2014-12-02 12:20:50 -03:00

pageinspect--1.3--1.4.sql

Add forgotten file in commit d6061f83a1

2015-11-25 16:59:07 +03:00

pageinspect--1.4--1.5.sql

Update pageinspect extension for parallel query.

2016-06-09 17:18:09 -04:00

pageinspect--1.5--1.6.sql

pageinspect: Add bt_page_items function with bytea argument

2017-04-04 23:52:55 -04:00

pageinspect--1.5.sql

Update pageinspect extension for parallel query.

2016-06-09 17:18:09 -04:00

pageinspect--1.6--1.7.sql

Skip full index scan during cleanup of B-tree indexes when possible

2018-04-04 19:29:00 +03:00

pageinspect--1.7--1.8.sql

pageinspect: Fix types used for bt_metap() columns.

2020-03-07 16:44:53 -08:00

pageinspect.control

Add to pageinspect function to make t_infomask/t_infomask2 human-readable

2019-09-12 15:06:00 +09:00

pageinspect.h

Update copyrights for 2020

2020-01-01 12:21:45 -05:00

rawpage.c

Remove excess parens in ereport() calls

2020-01-30 13:32:04 -03:00