mirror of
				https://github.com/postgres/postgres.git
				synced 2025-10-29 22:49:41 +03:00 
			
		
		
		
	Block numbers are 32-bit unsigned integers. Therefore, the smallest SQL integer type that they can fit in is bigint. However, in the pageinspect module, most input and output parameters dealing with block numbers were declared as int. The behavior with block numbers larger than a signed 32-bit integer was therefore dubious. Change these arguments to type bigint and add some more explicit error checking on the block range. (Other contrib modules appear to do this correctly already.) Since we are changing argument types of existing functions, in order to not misbehave if the binary is updated before the extension is updated, we need to create new C symbols for the entry points, similar to how it's done in other extensions as well. Reported-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://www.postgresql.org/message-id/flat/d8f6bdd536df403b9b33816e9f7e0b9d@G08CNEXMBPEKD05.g08.fujitsu.local
		
			
				
	
	
		
			22 lines
		
	
	
		
			728 B
		
	
	
	
		
			SQL
		
	
	
	
	
	
			
		
		
	
	
			22 lines
		
	
	
		
			728 B
		
	
	
	
		
			SQL
		
	
	
	
	
	
| CREATE TABLE test1 (x int, y int[]);
 | |
| INSERT INTO test1 VALUES (1, ARRAY[11, 111]);
 | |
| CREATE INDEX test1_y_idx ON test1 USING gin (y) WITH (fastupdate = off);
 | |
| 
 | |
| \x
 | |
| 
 | |
| SELECT * FROM gin_metapage_info(get_raw_page('test1_y_idx', 0));
 | |
| SELECT * FROM gin_metapage_info(get_raw_page('test1_y_idx', 1));
 | |
| 
 | |
| SELECT * FROM gin_page_opaque_info(get_raw_page('test1_y_idx', 1));
 | |
| 
 | |
| SELECT * FROM gin_leafpage_items(get_raw_page('test1_y_idx', 1));
 | |
| 
 | |
| INSERT INTO test1 SELECT x, ARRAY[1,10] FROM generate_series(2,10000) x;
 | |
| 
 | |
| SELECT COUNT(*) > 0
 | |
| FROM gin_leafpage_items(get_raw_page('test1_y_idx',
 | |
|                         (pg_relation_size('test1_y_idx') /
 | |
|                          current_setting('block_size')::bigint)::int - 1));
 | |
| 
 | |
| DROP TABLE test1;
 |