config

contrib

adminpack

amcheck

auth_delay

auto_explain

bloom

bool_plperl

btree_gin

btree_gist

citext

cube

dblink

dict_int

expected

sql

dict_int.sql

.gitignore

Makefile

dict_int--1.0.sql

dict_int.c

dict_int.control

dict_xsyn

earthdistance

file_fdw

fuzzystrmatch

hstore

hstore_plperl

hstore_plpython

intagg

intarray

isn

jsonb_plperl

jsonb_plpython

lo

ltree

ltree_plpython

oid2name

old_snapshot

pageinspect

passwordcheck

pg_buffercache

pg_freespacemap

pg_prewarm

pg_stat_statements

pg_surgery

pg_trgm

pg_visibility

pgcrypto

pgrowlocks

pgstattuple

postgres_fdw

seg

sepgsql

spi

sslinfo

start-scripts

tablefunc

tcn

test_decoding

tsm_system_rows

tsm_system_time

unaccent

uuid-ossp

vacuumlo

xml2

Makefile

README

contrib-global.mk

doc

src

.dir-locals.el

.editorconfig

.gitattributes

.gitignore

COPYRIGHT

GNUmakefile.in

HISTORY

Makefile

README

README.git

aclocal.m4

configure

configure.ac

Tom Lane d01f03a495 Preserve integer and float values accurately in (de)serialize_deflist. ...

Previously, this code just smashed all types of DefElem values to
strings, cavalierly reasoning that nobody would care.  But in point of
fact, most of the defGetFoo functions do distinguish among different
input syntaxes; for instance defGetBoolean will accept 1 as an integer
but not "1" as a string.  This led to CREATE/ALTER TEXT SEARCH
DICTIONARY accepting 0 and 1 as values for boolean dictionary
properties, only to have the dictionary fail at runtime.

We can upgrade this behavior by teaching serialize_deflist that it
does not need to quote T_Integer or T_Float nodes' values on output,
and then teaching deserialize_deflist to restore unquoted integer or
float values as the appropriate node type.  This should not break
anything using pg_ts_dict.dictinitoption, since that field is just
defined as being something valid to include in CREATE TEXT SEARCH
DICTIONARY.

deserialize_deflist is also used to parse the options arguments
for the ts_headline family of functions, but so far as I can see
this won't cause any problems there either: the only consumer of
that output is prsd_headline which always uses defGetString.
(Really that's a bad idea, but I won't risk changing it here.)

This is surely a bug fix, but given the lack of field complaints
I don't think it's necessary to back-patch.

Discussion: https://postgr.es/m/CAMkU=1xRcs_BUPzR0+V3WndaCAv0E_m3h6aUEJ8NF-sY1nnHsw@mail.gmail.com

2020-03-10 12:30:02 -04:00

..

dict_int.sql

Preserve integer and float values accurately in (de)serialize_deflist.

2020-03-10 12:30:02 -04:00