1
0
mirror of https://github.com/postgres/postgres.git synced 2025-11-28 11:44:57 +03:00
Commit Graph

5397 Commits

Author SHA1 Message Date
Tom Lane
c80184552f Fix assign_session_authorization() to not be confused by all-numeric
user names.  Per recent reports.
2003-02-01 18:31:37 +00:00
Tom Lane
b52fe8dcc8 Tweak bison build rules so that we get the same error messages from
bison 1.875 and later as we did from earlier bison releases.  Eventually
we will probably want to adopt the newer message spelling ... but not yet.
Per recent discussion on pgpatches.
Note: I didn't change the build rules for bootstrap, ecpg, or plpgsql
grammars, since these do not affect regression test results.
2003-01-31 20:58:28 +00:00
Tom Lane
d6242b373b SPI_exec shouldn't return SPI_OK_SELECT if it hasn't actually returned
a tuple table.  Fixes core dump in pltcl (and probably other PLs) when
executing a query rewritten by a rule.  Per bug report from Wolfgang Walter.
2003-01-29 15:24:57 +00:00
Tom Lane
726b7f3b3c Repair array subscript overrun identified by Yichen Xie. Reduce the
value of MAX_TIME_PRECISION in floating-point-timestamp-storage case
from 13 to 10, which is as much as time_out is actually willing to print.
(The alternative of increasing the number of digits we are willing to
print looks risky; we might find ourselves printing roundoff garbage.)
2003-01-29 01:09:03 +00:00
Tom Lane
8672494da5 Fix array subscript overruns identified by Yichen Xie. 2003-01-29 01:01:15 +00:00
Tom Lane
c95ed02c49 Convert variable name to canonical spelling before checking for matches
in GUCArrayAdd/GUCArrayDelete.  This prevents the multiple-entry bug
exhibited by Frank Lupo 28-Jan-2003.
2003-01-28 18:04:13 +00:00
Bruce Momjian
93c3f36d22 Revert off setting mention for client_min_messages.
Set log_min_error_messages to the proper and agreed-upon default, PANIC
(off).  (BACKPATCH)
2003-01-28 03:44:09 +00:00
Tom Lane
a825ad2bda Fix obsolete error message (isImmutable doesn't exist). 2003-01-23 15:18:50 +00:00
Tom Lane
01376c215c Change CREATE TABLE AS / SELECT INTO to create the new table with OIDs,
for backwards compatibility with pre-7.3 behavior.  Per discussion on
pgsql-general and pgsql-hackers.
2003-01-23 05:10:57 +00:00
Tom Lane
c0f8da118b Make estimation of mergejoin scan selectivities more robust, per recent
example from RaÇl GutiÅrrez.
2003-01-22 20:17:07 +00:00
Tom Lane
1f74045675 Fix coredump problem in plpgsql's RETURN NEXT. When a SELECT INTO
that's selecting into a RECORD variable returns zero rows, make it
assign an all-nulls row to the RECORD; this is consistent with what
happens when the SELECT INTO target is not a RECORD.  In support of
this, tweak the SPI code so that a valid tuple descriptor is returned
even when a SPI select returns no rows.
2003-01-21 22:06:36 +00:00
Tom Lane
db398d05be Repair an embarrassingly large number of alphabetization mistakes in the
datetime token tables.  Even more embarrassing, the regression tests
revealed some of the problems --- but evidently the bogus output wasn't
questioned.  Add code to postmaster startup to directly check the tables
for correct ordering, in hopes of not being embarrassed like this again.
2003-01-16 00:27:17 +00:00
Bruce Momjian
1fb7158124 More comment cleanups for shared_buffers in postgresql.conf. 2003-01-15 20:50:18 +00:00
Bruce Momjian
430fd35368 Update shared_buffer comment in postgresql.conf. 2003-01-15 20:41:33 +00:00
Tatsuo Ishii
8b434d647e Fix typo in an error messages 2003-01-11 06:59:30 +00:00
Bruce Momjian
8ca66703e2 > > This patch improves the documentation for the shared_buffers GUC param.
>
> I'd suggest that the runtime.sgml description explicitly say "values of
> at least a few thousand are recommended for production installations".

Neil Conway
2003-01-11 05:04:27 +00:00
Bruce Momjian
4a9588f671 Fix indenting of log_min_error_statement. 2003-01-09 05:19:18 +00:00
Tom Lane
9ecfdbcae1 Repair inconsistent rounding behavior for timestamp, time, interval,
per gripe from Csaba Nagy.  There is still potential for platform-specific
behavior for values that are exactly halfway between integers, but at
least we now get the expected answer for all other cases.
2003-01-09 01:07:18 +00:00
Bruce Momjian
9260e79d11 Remove 'const' from secure_write, to prevent compiler warning. 2003-01-08 23:34:37 +00:00
Bruce Momjian
ce83fc68aa The second was that renegotiation was just plain broken. I can't
believe I didn't notice this before -- once 64k was sent to/from the
server the client would crash.  Basicly, in 7.3 the server SSL code set
the initial state to "about to renegotiate" without actually starting
the renegotiation.  In addition, the server and client didn't properly
handle the SSL_ERROR_WANT_(READ|WRITE) error.  This is fixed in the
second patch.

Nathan Mueller
2003-01-08 23:18:35 +00:00
Bruce Momjian
671231f588 I was playing around with 7.3.1 and found some more SSL problems. The
first, that I missed when checking over 7.3.1, was that the client
method was switched to SSLv23 along with the server.  The SSLv23 client
method does SSLv2 by default, but can also understand SSLv3.  In our
situation the SSLv2 backwords compatibility is really only needed on the
server.  This is the first patch.

The last thing is that I found a way for the server to understand SSLv2
HELLO messages (sent by pre-7.3 clients) but then get them to talk
SSLv3.  This is the last one.

Nathan Mueller
2003-01-08 22:57:05 +00:00
Bruce Momjian
fdb1c80747 Fix dumping of DEFERRABLE/INITIALLY DEFERRED:
> The big problem is that while pg_dump's dump_trigger() looks at
> tginitdeferred and dumps accordingly, pg_get_constraintdef doesn't look
> at tginitdeferred, and therefore doesn't record the requirement as part
> of ALTER TABLE ADD CONSTRAINT.

pg_get_constraintdef should probably be looking at condeferrable and
condeferred in the pg_constraint row it's looking at.  Maybe something
like the attached.

(Added, output only non-default values.)

Stephan Szabo
2003-01-08 22:54:36 +00:00
Tom Lane
a899179c8c Repair bug noticed by Deepak Bhole: a shell type should have a dependency
on its namespace, so that it will go away if the schema is dropped.
2003-01-08 21:40:49 +00:00
Tom Lane
40cb1361a6 Fix for bug #866. 7.3 contains new logic for avoiding redundant calls to
the index AM when we know we are fetching a unique row.  However, this
logic did not consider the possibility that it would be asked to fetch
backwards.  Also fix mark/restore to work correctly in this scenario.
2003-01-08 19:41:57 +00:00
Tom Lane
2e0e101b42 Fix inherited UPDATE for cases where child column numbering doesn't
match parent table.  This used to work, but was broken in 7.3 by
rearrangement of code that handles targetlist sorting.  Add a regression
test to catch future breakage.
2003-01-05 00:56:56 +00:00
Tom Lane
f159bce09f Add missing include --- seems include file references are different in
CVS tip than in this branch.
2003-01-05 00:49:59 +00:00
Peter Eisentraut
b19a0c70d2 Translation updates 2003-01-04 10:26:28 +00:00
Tom Lane
573fe25203 fastpath code neglected to check whether user has privileges to call the
target function.  Also, move SetQuerySnapshot() call to avoid assert
failure when a fastpath call is attempted in an aborted transaction.
2003-01-01 21:57:18 +00:00
Tom Lane
5271e60ff3 Point does not return a center of lseg.
Kenji Sugita
2002-12-30 02:18:39 +00:00
Tom Lane
629df5f489 Adjust hash table sizing algorithm to avoid integer overflow in
ExecHashJoinGetBatch().  Fixes core dump on large hash joins, as in
example from Rae Stiening.
2002-12-29 22:29:03 +00:00
Tom Lane
b37d6373f0 Deliver better error message when a relation name is used in an expression.
Per report from Ian Barwick.
2002-12-27 20:06:28 +00:00
Bruce Momjian
31f7f574bd Trivial patch to increase max_fsm_pages as per earlier discussion.
Philip Warner
2002-12-27 14:07:14 +00:00
Bruce Momjian
7c3e3cd96a Update SSL error message for improper permissions. Backpatch to 7.3.X. 2002-12-23 22:19:26 +00:00
PostgreSQL Daemon
d2f0761b82 From the SSL_CTX_new man page:
"SSLv23_method(void), SSLv23_server_method(void), SSLv23_client_method(void)

 A TLS/SSL connection established with these methods will understand the SSLv2,
 SSLv3, and TLSv1 protocol. A client will send out SSLv2 client hello messages
 and will indicate that it also understands SSLv3 and TLSv1. A server will
 understand SSLv2, SSLv3, and TLSv1 client hello messages. This is the best
 choice when compatibility is a concern."

This will maintain backwards compatibility for those us that don't use
TLS connections ...
2002-12-18 13:20:03 +00:00
Tom Lane
f599d56f51 Fix ALTER TABLE ADD COLUMN to disallow the same column types that are
disallowed by CREATE TABLE (eg, pseudo-types); also disallow these types
from being introduced by the range-function syntax.  While at it, allow
CREATE TABLE to create zero-column tables, per recent pghackers discussion.
I am back-patching this into 7.3 since failure to disallow pseudo-types
is arguably a security hole.
2002-12-16 18:39:57 +00:00
Bruce Momjian
750b3f3825 The actual segfault was caused by a double pfree(), but ISTM that
failing to find pg_hba.conf should be a fatal error anyway, so I
increased the priority of the elog() from LOG to FATAL and refactored
the code a little bit.

Neil Conway
2002-12-14 18:49:43 +00:00
Bruce Momjian
96e9574037 Ok, I think I've gotten this figured out now. I saw this comment in
pqcomm.c, switched the ERROR logs to COMMERROR logs and it all works.
I've attached a patch to be-secure.c that fixes all my problems.

Nathan Mueller
2002-12-14 18:39:39 +00:00
Bruce Momjian
77a9708f85 Backpatch SSL fixes into 7.3.1. 2002-12-13 22:20:22 +00:00
Tom Lane
1c432d60d7 Guard against overrunning CTZName buffer when TZ is bogus. 2002-12-12 19:17:04 +00:00
Tom Lane
68df4f7ca8 Back-patch fix to prevent core dump in EXPLAIN if optimizer has
simplified function call to a constant.  (7.3 won't actually execute
such a plan anyway, but core dump is bad regardless.)
2002-12-12 16:16:58 +00:00
Bruce Momjian
bab9c3d555 Fix line count error reporting in config files, like pg_hba.conf, per
report from Oliver Elphick.

Backpatch to 7.3.
2002-12-11 22:17:31 +00:00
Peter Eisentraut
ac3534f973 Translation updates 2002-12-10 20:00:27 +00:00
Peter Eisentraut
39610c8f03 Fix Latin1/Unicode conversion by selecting the right table. 2002-12-09 19:42:31 +00:00
Bruce Momjian
a92a4010a7 As far as I figured from the source code this function only deals with
cleaning up locale names and nothing else. Since all the locale names
are in plain  ASCII I think it will be safe to use ASCII-only lower-case
conversion.

Nicolai Tufar
2002-12-09 17:45:17 +00:00
Tom Lane
b3b39591c1 Explain's code for showing quals of SubqueryScan nodes has been broken
all along; not noticed till now.  It's a scan not an upper qual ...
2002-12-06 19:28:13 +00:00
Tom Lane
500677c40f localbuf.c must be able to do blind writes. 2002-12-05 22:48:10 +00:00
Tom Lane
0e98ae22d3 Avoid pulling up sublinks from a subselect's targetlist. Works around
problems that occur if sublink is referenced via a join alias variable.
Perhaps this can be improved later, but a simple and safe fix is needed
for 7.3.1.
2002-12-05 21:46:55 +00:00
Bruce Momjian
24536e5b3f Allow 'password' encryption even when pg_shadow has MD5 passwords, per
report from Terry Yapt and Hiroshi.

Backpatch to 7.3.
2002-12-05 18:40:08 +00:00
Tom Lane
b8b92c6908 Repair oversight in recent change of dependency extraction code: when
recursing to handle a join alias var, the context had better be set to
be appropriate to the join var's query level.  Per report from Hristo Neshev.
2002-12-04 20:00:19 +00:00
Tom Lane
4390ebc505 Repair core dump when trying to delete an entry from an already-NULL
datconfig or useconfig field.  Per report from Dustin Sallings.
2002-12-02 05:21:02 +00:00