Marc G. Fournier
71cd646a34
More include file cleanups
1996-11-03 12:11:19 +00:00
Marc G. Fournier
dd71c36933
That pretty much totally cleans up the includes files here.
1996-11-03 10:57:24 +00:00
Marc G. Fournier
66a518735f
Finish cleaning up -I lines
1996-11-03 09:07:03 +00:00
Marc G. Fournier
0c960e7fc0
More include file cleanups
1996-11-03 08:17:38 +00:00
Marc G. Fournier
a95674269f
More intelligent #include cleanups, as pointed out by Bryan...
...
Compiled with -Wall -Werror
1996-11-01 09:41:41 +00:00
Marc G. Fournier
ea94d639d0
Okay, so I was going backwards on my include cleanup...
...
Pointed out by Bryan (in a subtle way *grin*)
1996-11-01 09:12:18 +00:00
Marc G. Fournier
b13f5c25e2
More of the same...clean Makefile, add include files
1996-10-31 08:52:54 +00:00
Marc G. Fournier
ab2444032a
Same clean up of Makefile, and addition of include files
1996-10-31 08:32:23 +00:00
Marc G. Fournier
f578f8fb68
Cleaned out -I../.. -I../../include from Makefile
...
Added missing include files
1996-10-31 08:28:53 +00:00
Marc G. Fournier
367ade186f
Remove -I../.. and -I../../include from Makefile
...
Add some missing include files
1996-10-31 08:24:47 +00:00
Marc G. Fournier
ea04818002
Add a couple of missing includes
1996-10-31 08:09:47 +00:00
Marc G. Fournier
ba4ad2c71a
Added misc include files
1996-10-31 07:48:38 +00:00
Marc G. Fournier
c59b3afbf1
Well, normally there wouldn't be anything in -I../.., and in a minute, there
...
won't be...
1996-10-31 07:22:07 +00:00
Marc G. Fournier
5565d32e10
There is no -I../.. include files...
1996-10-31 07:04:50 +00:00
Marc G. Fournier
69c7f25bed
Fixes:
...
I found another bug in btree index. Looking at the code it seems that NULL
keys are never used to build or scan a btree index (see the explain commands
in the example). However this is not the case when a null key is retrieved
in an outer loop of a join select and used in an index scan of an inner loop.
This bug causes at least three kinds of problems:
1) the backend crashes when it tries to compare a text string with a null.
2) it is not possible to find tuples with null keys in a join.
3) null is considered equal to 0 when the datum is passed by value, see
the last query.
Submitted by: Massimo Dal Zotto <dz@cs.unitn.it >
1996-10-30 06:08:10 +00:00
Bryan Henderson
b0d6f0aa63
Simplify make files, add full dependencies.
1996-10-27 09:55:05 +00:00
Marc G. Fournier
716d506a81
Make sure the btree patch gets into 2.0 as well...
...
Still submitted by: Massimo Dal Zotto <dz@cs.unitn.it >
1996-10-25 09:55:36 +00:00
Marc G. Fournier
c471d2bdeb
Take out the PERFECT_MMGR #ifdefs:
...
My guess is that the thing had bugs, and the pfree was commented out.
The thing is probabally free'ed anyway at the end, so it was not a bad
thing.
If it does cause a bug, it will generate an error when hit, so I say
unless someone else knows, let's remove it and run the regression test.
-Bruce
1996-10-24 06:30:40 +00:00
Marc G. Fournier
f36b2560a4
Major code cleanups from D'arcy (-Wall -Werror)
1996-10-23 07:42:13 +00:00
Marc G. Fournier
82b83f6f71
Cosmetic changes to ordering of #include files
1996-10-21 11:49:41 +00:00
Marc G. Fournier
8385d557d1
-Wall'd ... I missed a subdir under access :(
1996-10-21 07:38:20 +00:00
Marc G. Fournier
f47ffc9a4e
Make line 159:bp = NULL, to quiet compiler
...
Suggested by: Randy Terbush <randy@zyzzyva.com >
1996-10-21 07:18:08 +00:00
Marc G. Fournier
c9f8bad182
-Wall'd
...
That finishes access/*
1996-10-21 07:15:18 +00:00
Marc G. Fournier
b446f38510
-Wall'd
1996-10-21 05:59:49 +00:00
Marc G. Fournier
ede7e6b045
-Wall'd
1996-10-21 05:45:21 +00:00
Marc G. Fournier
0452227989
-Wall Cleanup of gist subdirectory
1996-10-21 05:14:02 +00:00
Marc G. Fournier
95874fa034
-Wall cleanup of gist subdirectory:
...
- cleaned out unused variables
- added missing prototype headers
One outstanding -Werror failure:
/home/staff/scrappy/postgres/2.0/cvs/postgres95/src/backend/access/gist/giststra
t.c:117: warning: missing braces around initializer for `GISTEvaluationData.expr
ession'
1996-10-21 05:11:00 +00:00
Marc G. Fournier
d458a1c747
Other then:
...
indextuple.c:159: warning: `bp' might be used uninitialized in this function
this directory passes -Wall -Werror under FreeBSD
1996-10-20 22:04:49 +00:00
Marc G. Fournier
13cd836d62
#include file cleanup
1996-10-20 10:53:18 +00:00
Marc G. Fournier
e1220b7c21
More #include cleanups
...
Once access/* is cleaned out, will redo using -Wall on compile to
make sure that all prototyping is correct
1996-10-20 09:27:24 +00:00
Marc G. Fournier
5a0b450c78
First pass at fixing my own mistakes
...
Mainly...fix up the includes I removed, as well as prototypes
Pointed out by D'Arcy
1996-10-20 08:32:11 +00:00
Marc G. Fournier
dd007d4c39
Another directory cleaned out
1996-10-20 06:56:04 +00:00
Marc G. Fournier
3cb7ff8db2
Okay...another directory cleaned out and compilable
1996-10-20 06:34:30 +00:00
Marc G. Fournier
0eac5b0ed5
Welp, another subdirectory cleaned out of redundant/unused #include
...
files
1996-10-19 06:27:33 +00:00
Marc G. Fournier
e77f64af62
There...that pretty much cleans up redundant/unused #includes in
...
access/common...how many more directories to go? :)
1996-10-19 04:51:44 +00:00
Marc G. Fournier
d7dd05db55
Another cleaned up
1996-10-19 03:39:04 +00:00
Marc G. Fournier
5dedad99a1
One at a time...another one is complete...
1996-10-19 03:28:20 +00:00
Marc G. Fournier
69b42eb1a3
another one with #include file clean'd up
1996-10-19 03:12:50 +00:00
Marc G. Fournier
9834913cd0
All #include's removed from *.h files, so cleaning up the .c #includes...
...
First file of, what...1000's?
1996-10-18 19:01:16 +00:00
Vadim B. Mikheev
327d900b51
Move #define PageIsNew (true if page is not initialize) to bufpage.h
1996-10-18 07:43:43 +00:00
Marc G. Fournier
2ecb7e5e2c
Moved '#define *DEBUG' defines to config.h, and document where first
...
found.
Document any '#ifdef' segments found in config.h
1996-10-18 05:21:27 +00:00
Marc G. Fournier
6e420677dd
Moved '#define *DEBUG' defines to config.h, and document where first
...
found.
Document any '#ifdef' segments found in config.h
Remove gistold.c, since it was older copy of gist.c
1996-10-18 05:21:09 +00:00
Marc G. Fournier
6c8465f69b
#define cleanup: moved #define IPORTAL_DEBUG to config.h
1996-10-18 04:54:47 +00:00
Marc G. Fournier
3023dc6af0
A few changes to cleanup the code.
...
- Added the header access/heapam.h.
- Changed all instances of "length" to "data_length" to quiet
the compiler.
- initialized a few variables. The compiler couldn't see that
the code guaranteed that these would be initialized before
being dereferenced. If anyone wants to check my work follow
the usage of these variables and make sure that this true
and wasn't actually a bug in the original code.
- added a missing break statement to a default case. This
was a benign error but bad style.
- layed out heap_sysattrlen differently. I think this way
makes the structure of the code crystal clear. There should
be no actual difference in the actual behaviour of the code.
Submitted by: darcy@druid.druid.com (D'Arcy J.M. Cain)
1996-09-19 20:00:37 +00:00
Marc G. Fournier
3c0f8ed4ae
Remove all traces of machine.h and redundant calls to c.h where
...
postgres.h already pulled in (postgres.h includes c.h)
1996-08-27 22:15:17 +00:00
Marc G. Fournier
9247b29228
The use of include files is a mess...alot of redundancy, it seems...
...
First Step: Centralize them under on src/include hierarchy
1996-08-27 21:49:14 +00:00
Marc G. Fournier
e1f31a2bb6
added #include "config.h" for ESCAPE_PATCH define
1996-08-27 07:42:29 +00:00
Marc G. Fournier
bfc308d196
Damn, we really need to clean up this "include file" dilemna...
...
include files *everywhere* ;(
1996-08-26 23:04:07 +00:00
Marc G. Fournier
e78fe652f4
Oops, thanks to Dan McGuirk for pointing out that I missed part of
...
the commit :(
Here's the rest of the GiST code thta was missing...
1996-08-26 20:02:12 +00:00
Marc G. Fournier
a2740a455f
There, now we support GiST...now what? :)
1996-08-26 06:32:06 +00:00