Marc G. Fournier
20b4c46e26
Fixes: Errors when PQexec() in backend creates temp
...
relations and transaction is aborted
Submitted by: wieck@sapserv.debis.de (Jan Wieck)
1996-10-24 07:55:54 +00:00
Marc G. Fournier
e152661200
Fixes:
...
It's bug in nodeAgg.c on lines 241, 242:
null_array = malloc(nagg);
for (i=0;i<nagg;i++)
null_array[i] = 'n';
oneTuple = heap_formtuple(tupType, tupValue, null_array);
- your query has not only aggregates but also 'group by-ed' fields and so
null_array should contain tupType->natts elements (tupType->natts > nagg in
your case).
Patch follows and it's very simple.
VAdim
1996-10-24 06:32:01 +00:00
Marc G. Fournier
c471d2bdeb
Take out the PERFECT_MMGR #ifdefs:
...
My guess is that the thing had bugs, and the pfree was commented out.
The thing is probabally free'ed anyway at the end, so it was not a bad
thing.
If it does cause a bug, it will generate an error when hit, so I say
unless someone else knows, let's remove it and run the regression test.
-Bruce
1996-10-24 06:30:40 +00:00
Marc G. Fournier
f36b2560a4
Major code cleanups from D'arcy (-Wall -Werror)
1996-10-23 07:42:13 +00:00
Bryan Henderson
2db54b8e4f
Update "planner" directory to "optimizer" in include paths in this dead code.
1996-10-23 07:14:43 +00:00
Marc G. Fournier
82b83f6f71
Cosmetic changes to ordering of #include files
1996-10-21 11:49:41 +00:00
Marc G. Fournier
9a7fda57ee
-Wall'd
1996-10-21 09:37:26 +00:00
Marc G. Fournier
aa907f7d0c
-Wall'd
1996-10-21 08:31:23 +00:00
Marc G. Fournier
8385d557d1
-Wall'd ... I missed a subdir under access :(
1996-10-21 07:38:20 +00:00
Marc G. Fournier
f47ffc9a4e
Make line 159:bp = NULL, to quiet compiler
...
Suggested by: Randy Terbush <randy@zyzzyva.com >
1996-10-21 07:18:08 +00:00
Marc G. Fournier
c9f8bad182
-Wall'd
...
That finishes access/*
1996-10-21 07:15:18 +00:00
Marc G. Fournier
b446f38510
-Wall'd
1996-10-21 05:59:49 +00:00
Marc G. Fournier
ede7e6b045
-Wall'd
1996-10-21 05:45:21 +00:00
Marc G. Fournier
0452227989
-Wall Cleanup of gist subdirectory
1996-10-21 05:14:02 +00:00
Marc G. Fournier
95874fa034
-Wall cleanup of gist subdirectory:
...
- cleaned out unused variables
- added missing prototype headers
One outstanding -Werror failure:
/home/staff/scrappy/postgres/2.0/cvs/postgres95/src/backend/access/gist/giststra
t.c:117: warning: missing braces around initializer for `GISTEvaluationData.expr
ession'
1996-10-21 05:11:00 +00:00
Marc G. Fournier
d458a1c747
Other then:
...
indextuple.c:159: warning: `bp' might be used uninitialized in this function
this directory passes -Wall -Werror under FreeBSD
1996-10-20 22:04:49 +00:00
Marc G. Fournier
13cd836d62
#include file cleanup
1996-10-20 10:53:18 +00:00
Marc G. Fournier
e1220b7c21
More #include cleanups
...
Once access/* is cleaned out, will redo using -Wall on compile to
make sure that all prototyping is correct
1996-10-20 09:27:24 +00:00
Marc G. Fournier
5a0b450c78
First pass at fixing my own mistakes
...
Mainly...fix up the includes I removed, as well as prototypes
Pointed out by D'Arcy
1996-10-20 08:32:11 +00:00
Marc G. Fournier
dd007d4c39
Another directory cleaned out
1996-10-20 06:56:04 +00:00
Marc G. Fournier
3cb7ff8db2
Okay...another directory cleaned out and compilable
1996-10-20 06:34:30 +00:00
Marc G. Fournier
5eee45ea05
Add HAVE_Cplusplus= true to BSD44_derived Makefile.inc, as I know that
...
FreeBSD/NetBSD both ship with gcc 2.7.x
1996-10-19 06:36:52 +00:00
Marc G. Fournier
0eac5b0ed5
Welp, another subdirectory cleaned out of redundant/unused #include
...
files
1996-10-19 06:27:33 +00:00
Marc G. Fournier
e77f64af62
There...that pretty much cleans up redundant/unused #includes in
...
access/common...how many more directories to go? :)
1996-10-19 04:51:44 +00:00
Marc G. Fournier
d7dd05db55
Another cleaned up
1996-10-19 03:39:04 +00:00
Marc G. Fournier
5dedad99a1
One at a time...another one is complete...
1996-10-19 03:28:20 +00:00
Marc G. Fournier
69b42eb1a3
another one with #include file clean'd up
1996-10-19 03:12:50 +00:00
Marc G. Fournier
9834913cd0
All #include's removed from *.h files, so cleaning up the .c #includes...
...
First file of, what...1000's?
1996-10-18 19:01:16 +00:00
Marc G. Fournier
9caf84bc00
#include "postgres.h" is a standard include for all .c files, auto-including
...
config.h, c.h *and* elog.h...added elog.h
1996-10-18 18:28:33 +00:00
Vadim B. Mikheev
bc50067426
1. Reap deleted/unused tuples on page-base
...
2. Reap unused tuples too
3. Reap empty pages
4. Check if a page is initialized, initialize it if not
and reap it
5. Binary search in list of reapped pages/tids to check
is the heap' tid pointed by a index' tuple on this list
(it's mu-u-uch faster)
1996-10-18 08:13:36 +00:00
Vadim B. Mikheev
327d900b51
Move #define PageIsNew (true if page is not initialize) to bufpage.h
1996-10-18 07:43:43 +00:00
Marc G. Fournier
94e825145d
Document more #ifdef's into config.h
...
Get rid of ESCAPE_PATCH ifdef, as its on by default, and there is no
apparent reason for turning it off...it fixes a bug
1996-10-18 05:59:17 +00:00
Marc G. Fournier
1c00e68fad
Moved definition of MAXPATHLEN to config.h
1996-10-18 05:50:04 +00:00
Marc G. Fournier
927e5887a0
Added a #define NEED_SIG_JMP to config.h
...
Removed #ifdef's for OPENLINK_PATCH. We enable it by default, and nobody
*has* to enable the functionality, but no reason to retain the "old code"
1996-10-18 05:47:12 +00:00
Marc G. Fournier
2ecb7e5e2c
Moved '#define *DEBUG' defines to config.h, and document where first
...
found.
Document any '#ifdef' segments found in config.h
1996-10-18 05:21:27 +00:00
Marc G. Fournier
6e420677dd
Moved '#define *DEBUG' defines to config.h, and document where first
...
found.
Document any '#ifdef' segments found in config.h
Remove gistold.c, since it was older copy of gist.c
1996-10-18 05:21:09 +00:00
Marc G. Fournier
6c8465f69b
#define cleanup: moved #define IPORTAL_DEBUG to config.h
1996-10-18 04:54:47 +00:00
Marc G. Fournier
2d8ffead24
Moved all the CFLAG -D's from the makefiles to config.h towards better
...
centralized configurations/porting...
1996-10-18 04:49:09 +00:00
Marc G. Fournier
d16bc9ce37
Centralize more of the defines from backend/port under config.h
...
Further ports should *really* avoid backend/port and make use of
config.h
1996-10-18 00:33:41 +00:00
Marc G. Fournier
a839456c41
Move "port specific" #ifdefs out of here and into config.h
...
- created a HAVE_TZSET define for this purpose
1996-10-17 23:59:45 +00:00
Bruce Momjian
83cb729887
More closing of relations left open by parser.
1996-10-14 03:53:53 +00:00
Bruce Momjian
81f2f81960
Removed const warning.
1996-10-13 18:39:41 +00:00
Bruce Momjian
54612f5141
D'Arcy change.
1996-10-13 18:38:51 +00:00
Bruce Momjian
baf9a6e24c
Added include needed for recent addition.
...
I hope everyone has sys/socket.h.
1996-10-13 18:38:04 +00:00
Bruce Momjian
e6cacf9211
Added include needed for recent addition.
1996-10-13 18:37:19 +00:00
Bruce Momjian
86be8677a9
Added consistent include file handling for MAXHOSTNAMELEN.
...
If I have introduced any syntax errors with this, I will patch them in
the morning, and Marc will have a good laugh.
1996-10-13 04:50:27 +00:00
Bruce Momjian
abb1b3e770
I checked the alter table code, and started suspecting the relation
...
cache. I found if I manually added a line to flush the whole relation
cache, the assert error disappeared. Looking through the code, I found
that the relation cache is flushed at the end of each query if the
reference count is zero for the relation. However, printf's showed that
the rd_relcnt(reference count) for the accessed query was not returning
to zero after each query.
It turns out the parser was doing a heap_ropen in parser/analyze.c to
get information about the table's columns, but was not doing a
heap_close.
This was causing the query after the ALTER TABLE ADD to see the old
table structure, and the executor's assert was reporting the problem.
1996-10-13 04:26:39 +00:00
Bryan Henderson
bef3c89a1c
Fix prototypes so postmaster.c will compile.
1996-10-13 04:01:05 +00:00
Bryan Henderson
785234d6ca
New host-based authentication -- send error message when authentication fails
1996-10-12 07:48:49 +00:00
Bryan Henderson
4b5c977782
New host-based authentication with ident
1996-10-12 07:47:12 +00:00