Tom Lane
1402201463
Clean up checking of relkind for ALTER TABLE and LOCK TABLE commands.
...
Disallow cases like adding constraints to sequences :-(, and eliminate
now-unnecessary search of pg_rewrite to decide if a relation is a view.
2001-01-07 00:05:22 +00:00
Tom Lane
deb21f0f80
Log memory context stats to stderr when reporting a 'Memory exhausted'
...
error, so as to provide a starting point for debugging.
2001-01-06 21:59:39 +00:00
Tom Lane
e69b8d4655
Fix memory leak in relcache handling of rules: allocate rule parsetrees
...
in per-entry sub-memory-context, where they were supposed to go, rather
than in CacheMemoryContext where the code was putting them. Must've
suffered a severe brain fade when I wrote this :-(
2001-01-06 21:53:18 +00:00
Peter Eisentraut
41fde54603
Polish help output. Allow --help to work with BSD getopts.
2001-01-06 20:57:26 +00:00
Tom Lane
24a4aff68e
No need for screen_size to be static.
2001-01-06 17:43:01 +00:00
Peter Eisentraut
3ff76734f6
Simplify the rules that explicitly allowed TYPE as a type name (which is
...
no longer the case). Add AND and TRAILING to ColLabel. All key words
except AS are now at least ColLabel's.
2001-01-06 10:50:02 +00:00
Tatsuo Ishii
a6944611e2
Fix copy to make it more robust against unexpected character
...
sequences. This is done by disabling multi-byte awareness when it's
not necessary. This is kind of a workaround, not a perfect solution.
However, there is no ideal way to parse broken multi-byte character
sequences. So I guess this is the best way what we could do right
now...
2001-01-06 03:33:17 +00:00
Hiroshi Inoue
4451ed3dfe
init_irels() is changed to be called in RelationCacheInitializePhase2()
...
so that transactional control could guarantee the consistency.
2001-01-06 01:48:59 +00:00
Tom Lane
682b128993
Fix NOT NULL option for plpgsql variables (doesn't look like it
...
could ever have worked...)
2001-01-06 01:43:01 +00:00
Tom Lane
0ad5e43772
Fix misplaced strdup(), which could lead to error messages referencing
...
deallocated memory later on.
2001-01-06 01:39:01 +00:00
Tom Lane
81d08fcffe
Rename and document some invalidation routines to make it clearer that
...
they don't themselves flush any cache entries, only add to to-do lists
that will be processed later.
2001-01-05 22:54:37 +00:00
Tom Lane
2fb6cc9045
Remove not-really-standard implementation of CREATE TABLE's UNDER clause,
...
and revert documentation to describe the existing INHERITS clause
instead, per recent discussion in pghackers. Also fix implementation
of SQL_inheritance SET variable: it is not cool to look at this var
during the initial parsing phase, only during parse_analyze(). See
recent bug report concerning misinterpretation of date constants just
after a SET TIMEZONE command. gram.y really has to be an invariant
transformation of the query string to a raw parsetree; anything that
can vary with time must be done during parse analysis.
2001-01-05 06:34:23 +00:00
Tom Lane
e62c38d0fc
Disallow creation of a child table by a user who does not own the parent
...
table, per pghackers discussion around 22-Dec-00.
2001-01-05 02:58:16 +00:00
Peter Eisentraut
257e17bc60
Correct path where to check for password file existance.
2001-01-04 17:25:09 +00:00
Tom Lane
afeb8c4819
Clean up some unnecessary fragility in EXECUTE command.
2001-01-04 02:38:02 +00:00
Tom Lane
f9d6ffc5c4
Repair guaranteed core dump in SPI_exec(). Guess this routine wasn't
...
used before ...
2001-01-04 02:36:52 +00:00
Hiroshi Inoue
3052a421d5
I neglected to remove a debug message,sorry.
2001-01-04 02:24:22 +00:00
Tom Lane
ea608bfd3b
pg_dump failed to handle backslashes embedded in function definitions
...
(and most other places where it needed to output a string literal, too,
except for data INSERT statements). Per bug report from Easter, 12/1/00.
2001-01-04 01:23:47 +00:00
Tom Lane
60500d58bc
Fix breakage of rules using NOTIFY actions, per bug report and patch
...
from sergiop@sinectis.com.ar .
2001-01-03 22:01:05 +00:00
Tom Lane
676cf18c5b
New file format for COPY BINARY, in accordance with pghackers discussions
...
of early December 2000. COPY BINARY is now TOAST-safe.
2001-01-03 20:04:10 +00:00
Tom Lane
8fd2e269f7
MakeRetrieveViewRuleName was scribbling on memory that didn't belong
...
to it. Bad dog.
2001-01-03 18:43:09 +00:00
Thomas G. Lockhart
a8aa2f95b4
Repair always-broken date_part('quarter',timestamp).
...
Previous result did not have correct month boundaries so anything near edge
cases was suspect (e.g. April was in Q1 and July, August were lumped into
Q2).
Thanks to Denis Osadchy <osadchy@turbo.nsk.su > for the report.
2001-01-03 16:48:02 +00:00
Bruce Momjian
6b75942c72
I've found a memory leak in libecpg of PostgreSQL 7.0.3.
...
The leak is caused by the memory allocation in
src/interfaces/ecpg/lib/execute.c in line 669 which is never freed.
Adding a "free(array_query);" after PQexec in line 671 seems to fix the
leak.
Thorsten Knabe
2001-01-02 22:03:02 +00:00
Tom Lane
3bdadd0426
Document tuple ordering differences as a possible cause of
...
regression test 'failures'.
2001-01-02 05:56:02 +00:00
Tom Lane
1b8a219eef
Clean up non-reentrant interface for hash_seq/HashTableWalk, so that
...
starting a new hashtable search no longer clobbers any other search
active anywhere in the system. Fix RelationCacheInvalidate() so that
it will not crash or go into an infinite loop if invoked recursively,
as for example by a second SI Reset message arriving while we are still
processing a prior one.
2001-01-02 04:33:24 +00:00
Tom Lane
25d88e4c53
Tweak temporary-installation setup so that it doesn't break when the
...
configured install --prefix begins with /data/...
2001-01-02 02:13:48 +00:00
Tom Lane
144ec3c148
Update geometry-alpha-precision.out per reports from Brent Verner and
...
Adriaan Joubert.
2001-01-01 23:18:18 +00:00
Tom Lane
ad0169b1b7
CLUSTER forgot to create a TOAST table for the clustered relation.
2001-01-01 21:35:00 +00:00
Tom Lane
9315ff5549
Ensure attcacheoff is written out as -1 when writing pg_attribute
...
tuples for a relation. Needed to prevent Assert failure in CLUSTER.
2001-01-01 21:33:31 +00:00
Tom Lane
473763e676
Update comment.
2001-01-01 21:22:54 +00:00
Tom Lane
19e68b5096
Mark geometric 'overlaps' operators (&&) as self-commutative.
2000-12-31 22:34:04 +00:00
Tom Lane
8972088dcb
Fix typo in error message.
2000-12-31 22:24:14 +00:00
Tom Lane
52522850fe
Don't say 'export PGHOST' or 'export PGPORT' unless we actually define
...
those variables. Some shells will invent an empty-string definition in
this case, which is not what we want.
2000-12-31 18:38:44 +00:00
Tom Lane
e41b8a0fdd
On further thought, we need a defense against empty PGPORT here too.
2000-12-31 18:23:21 +00:00
Tom Lane
45f92179d9
Ignore PGPORT environment variable if it is an empty string.
2000-12-31 18:15:58 +00:00
Tom Lane
ff6012e275
Reverse #if test to be defined(__osf__) rather than not-any-of-a-lot-
...
of-others.
2000-12-31 18:04:35 +00:00
Peter Eisentraut
3b2b7eb19e
Remove incorrect use of rl_special_prefixes until further evaluation.
2000-12-31 11:57:58 +00:00
Tom Lane
fada8ee41f
NetBSD/Alpha porting fixes from tom@minnesota.com.
2000-12-31 03:34:01 +00:00
Tom Lane
4723b2b99b
Be more careful about the difference between signed and unsigned ints.
...
Bug is revealed by OID regress test on 64-bit platforms.
2000-12-30 19:17:47 +00:00
Peter Eisentraut
74e2bf95ec
Remove C++ comment.
2000-12-30 16:48:49 +00:00
Vadim B. Mikheev
3e059b3802
1. WAL needs in zero-ed content of newly initialized page.
...
2. Log record for PageRepaireFragmentation now keeps array
of !LP_USED offnums to redo cleanup properly.
2000-12-30 15:19:57 +00:00
Peter Eisentraut
874b4fd618
Remove incorrect assert.
2000-12-30 14:47:06 +00:00
Vadim B. Mikheev
c193f19a39
Fixed misprint in heap update WALoging.
2000-12-30 06:52:34 +00:00
Tatsuo Ishii
c0f9597b31
Imporve messages.
2000-12-30 06:10:43 +00:00
Tom Lane
ee6a91682d
Apparently, special float8 comparison file for Alpha is only needed
...
when using vendor cc, not gcc.
2000-12-30 02:48:04 +00:00
Tom Lane
f83b221598
Clean up spinlock assembly code slightly (just cosmetic improvements)
...
for Alpha gcc case. For Alpha non-gcc case, replace use of
__INTERLOCKED_TESTBITSS_QUAD builtin with __LOCK_LONG_RETRY and
__UNLOCK_LONG. The former does not execute an MB instruction and
therefore was guaranteed not to work on multiprocessor machines.
The LOCK_LONG builtins produce code that is the same in all essential
details as the gcc assembler code.
2000-12-30 02:34:56 +00:00
Tom Lane
c23851bbe0
Paranoia about possible values of errno after a shmget/semget failure.
...
In theory we should always get EEXIST if there's a key collision, but
if the kernel code tests error conditions in a weird order, perhaps
EACCES or EIDRM could occur too.
2000-12-30 01:20:55 +00:00
Tom Lane
2153d1c106
Remove obsolete and unportable enable_plpgsql script. createlang has
...
been the supported and documented way to do this for a long time...
2000-12-30 00:50:44 +00:00
Peter Eisentraut
ab432f204a
Fix unportable use of '!' in shell commands.
2000-12-30 00:24:09 +00:00
Tom Lane
aa44078e21
column and tuple numbers should be int not size_t.
2000-12-29 22:46:37 +00:00