database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Improve code comment

Browse Source 
The previous wording was potentially confusing about the impact of the
OVERRIDING clause on generated columns.  Reword slightly to avoid
that.

Reported-by: jian he <jian.universality@gmail.com>
Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/CACJufxFMBe0nPXOQZMLTH4Ry5Gyj4m%2B2Z05mRi9KB4hk8rGt9w%40mail.gmail.com
This commit is contained in:
Peter Eisentraut
2025-07-01 18:42:07 +02:00
parent 1fd772d192
commit fff0d1edf5
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/rewrite/rewriteHandler.c
View File

@ -923,8 +923,9 @@ rewriteTargetListIU(List *targetList,
apply_default = true; apply_default = true;
/* /*
* Can only insert DEFAULT into generated columns, regardless of * Can only insert DEFAULT into generated columns. (The
* any OVERRIDING clauses. * OVERRIDING clause does not apply to generated columns, so we
* don't consider it here.)
*/ */
if (att_tup->attgenerated && !apply_default) if (att_tup->attgenerated && !apply_default)
{ {