database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Fix MAINTAIN privileges for toast tables and partitions.

Browse Source 
Commit 60684dd8 left loose ends when it came to maintaining toast
tables or partitions.

For toast tables, simply skip the privilege check if the toast table
is an indirect target of the maintenance command, because the main
table privileges have already been checked.

For partitions, allow the maintenance command if the user has the
MAINTAIN privilege on the partition or any parent.

Also make CLUSTER emit "skipping" messages when the user doesn't have
privileges, similar to VACUUM.

Author: Nathan Bossart
Reported-by: Pavel Luzanov
Reviewed-by: Pavel Luzanov, Ted Yu
Discussion: https://postgr.es/m/20230113231339.GA2422750@nathanxps13
This commit is contained in:
Jeff Davis
2023-01-13 15:32:37 -08:00
parent ff23b592ad
commit ff9618e82a
16 changed files with 126 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
doc/src/sgml/ref/analyze.sgml
View File

@ -156,7 +156,10 @@ ANALYZE [ VERBOSE ] [ <replaceable class="parameter">table_and_columns</replacea
analyze all tables in their databases, except shared catalogs.
(The restriction for shared catalogs means that a true database-wide
<command>ANALYZE</command> can only be performed by superusers and roles
with privileges of <literal>pg_maintain</literal>.)
with privileges of <literal>pg_maintain</literal>.) If a role has
permission to <command>ANALYZE</command> a partitioned table, it is also
permitted to <command>ANALYZE</command> each of its partitions, regardless
of whether the role has the aforementioned privileges on the partition.
<command>ANALYZE</command> will skip over any tables that the calling user
does not have permission to analyze.
</para>

17
doc/src/sgml/ref/cluster.sgml
View File

@ -69,10 +69,7 @@ CLUSTER [VERBOSE]
<para>
<command>CLUSTER</command> without any parameter reclusters all the
previously-clustered tables in the current database that the calling user
owns or has the <literal>MAINTAIN</literal> privilege for, or all such tables
if called by a superuser or a role with privileges of the
<link linkend="predefined-roles-table"><literal>pg_maintain</literal></link>
role. This form of <command>CLUSTER</command> cannot be
has privileges for. This form of <command>CLUSTER</command> cannot be
executed inside a transaction block.
</para>
@ -134,6 +131,18 @@ CLUSTER [VERBOSE]
<refsect1>
<title>Notes</title>
<para>
To cluster a table, one must have the <literal>MAINTAIN</literal> privilege
on the table or be the table's owner, a superuser, or a role with
privileges of the
<link linkend="predefined-roles-table"><literal>pg_maintain</literal></link>
role. If a role has permission to <command>CLUSTER</command> a partitioned
table, it is also permitted to <command>CLUSTER</command> each of its
partitions, regardless of whether the role has the aforementioned
privileges on the partition. <command>CLUSTER</command> will skip over any
tables that the calling user does not have permission to cluster.
</para>
<para>
In cases where you are accessing single rows randomly
within a table, the actual order of the data in the

5
doc/src/sgml/ref/lock.sgml
View File

@ -177,7 +177,10 @@ LOCK [ TABLE ] [ ONLY ] <replaceable class="parameter">name</replaceable> [ * ]
MODE</literal> (or a less-conflicting mode as described in <xref
linkend="explicit-locking"/>) is permitted. If a user has
<literal>SELECT</literal> privileges on the table, <literal>ACCESS SHARE
MODE</literal> is permitted.
MODE</literal> is permitted. If a role has permission to lock a
partitioned table, it is also permitted to lock each of its partitions,
regardless of whether the role has the aforementioned privileges on the
partition.
</para>
<para>

6
doc/src/sgml/ref/reindex.sgml
View File

@ -306,7 +306,11 @@ REINDEX [ ( <replaceable class="parameter">option</replaceable> [, ...] ) ] { DA
indexes on shared catalogs will be skipped unless the user owns the
catalog (which typically won't be the case), has privileges of the
<literal>pg_maintain</literal> role, or has the <literal>MAINTAIN</literal>
privilege on the catalog. Of course, superusers can always reindex anything.
privilege on the catalog. If a role has permission to
<command>REINDEX</command> a partitioned table, it is also permitted to
<command>REINDEX</command> each of its partitions, regardless of whether the
role has the aforementioned privileges on the partition. Of course,
superusers can always reindex anything.
</para>
<para>

5
doc/src/sgml/ref/vacuum.sgml
View File

@ -401,7 +401,10 @@ VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ <replaceable class="paramet
vacuum all tables in their databases, except shared catalogs.
(The restriction for shared catalogs means that a true database-wide
<command>VACUUM</command> can only be performed by superusers and roles
with privileges of <literal>pg_maintain</literal>.)
with privileges of <literal>pg_maintain</literal>.) If a role has
permission to <command>VACUUM</command> a partitioned table, it is also
permitted to <command>VACUUM</command> each of its partitions, regardless
of whether the role has the aforementioned privileges on the partition.
<command>VACUUM</command> will skip over any tables that the calling user
does not have permission to vacuum.
</para>