database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-13 07:41:39 +03:00
Code Activity

I had overlooked the fact that some fmgr-callable functions return void

Browse Source 
--- ie, they're only called for side-effects.  Add a PG_RETURN_VOID()
macro and use it where appropriate.  This probably doesn't change the
machine code by a single bit ... it's just for documentation.
This commit is contained in:
Tom Lane
2000-06-14 05:24:50 +00:00
parent 69cd08d9f7
commit ff7b9f5541
10 changed files with 41 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/access/gist/gist.c
View File

@ -6,7 +6,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/access/gist/gist.c,v 1.56 2000/06/13 07:34:27 tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/access/gist/gist.c,v 1.57 2000/06/14 05:24:35 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -303,7 +303,7 @@ gistbuild(PG_FUNCTION_ARGS)
pfree(nulls);
pfree(d);
PG_RETURN_POINTER(NULL); /* no real return value */
PG_RETURN_VOID();
}
/*
@ -1149,7 +1149,7 @@ gistdelete(PG_FUNCTION_ARGS)
WriteBuffer(buf);
PG_RETURN_POINTER(NULL); /* no real return value */
PG_RETURN_VOID();
}
void

8
src/backend/access/gist/gistscan.c
View File

@ -154,7 +154,7 @@ gistrescan(PG_FUNCTION_ARGS)
}
}
PG_RETURN_POINTER(NULL); /* no real return value */
PG_RETURN_VOID();
}
Datum
@ -190,7 +190,7 @@ gistmarkpos(PG_FUNCTION_ARGS)
gistfreestack(p->s_markstk);
p->s_markstk = o;
PG_RETURN_POINTER(NULL); /* no real return value */
PG_RETURN_VOID();
}
Datum
@ -226,7 +226,7 @@ gistrestrpos(PG_FUNCTION_ARGS)
gistfreestack(p->s_stack);
p->s_stack = o;
PG_RETURN_POINTER(NULL); /* no real return value */
PG_RETURN_VOID();
}
Datum
@ -247,7 +247,7 @@ gistendscan(PG_FUNCTION_ARGS)
gistdropscan(s);
/* XXX don't unset read lock -- two-phase locking */
PG_RETURN_POINTER(NULL); /* no real return value */
PG_RETURN_VOID();
}
static void