database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Fix datatype for number of heap tuples during last cleanup

Browse Source 
It appears that new fields introduced in 857f9c36 have inconsistent datatypes:
BTMetaPageData.btm_last_cleanup_num_heap_tuples is of float4 type,
while xl_btree_metadata.last_cleanup_num_heap_tuples is of double type.
IndexVacuumInfo.num_heap_tuples, which is a source of values for
both former fields is of double type.  So, make both those fields in
BTMetaPageData and xl_btree_metadata use float8 type in order to match the
precision of the source.  That shouldn't be double type, because we always
use types with explicit width in WAL.

Patch introduces incompatibility of on-disk format since 857f9c36 commit, but
that versions never was released, so just bump catalog version to avoid
possible confusion.

Author: Alexander Korortkov
This commit is contained in:
Teodor Sigaev
2018-04-19 11:28:03 +03:00
parent f97f0c921a
commit ff4943042f
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/include/access/nbtxlog.h
View File

@ -52,7 +52,7 @@ typedef struct xl_btree_metadata
BlockNumber fastroot;
uint32 fastlevel;
TransactionId oldest_btpo_xact;
double last_cleanup_num_heap_tuples;
float8 last_cleanup_num_heap_tuples;
} xl_btree_metadata;
/*