mirror of
https://github.com/postgres/postgres.git
synced 2025-05-02 11:44:50 +03:00
Sync our DTrace infrastructure with c.h's definition of type bool.
Since commit d26a810eb, we've defined bool as being either _Bool from <stdbool.h>, or "unsigned char"; but that commit overlooked the fact that probes.d has "#define bool char". For consistency, make it say "unsigned char" instead. This should be strictly a cosmetic change, but it seems best to be in sync. Formally, in the now-normal case where we're using <stdbool.h>, it'd be better to write "#define bool _Bool". However, then we'd need some build infrastructure to inject that configuration choice into probes.d, and it doesn't seem worth the trouble. We only use <stdbool.h> if sizeof(_Bool) is 1, so having DTrace think that bool parameters are "unsigned char" should be close enough. Back-patch to v12 where d26a810eb came in. Discussion: https://postgr.es/m/CAA4eK1LmaKO7Du9M9Lo=kxGU8sB6aL8fa3sF6z6d5yYYVe3BuQ@mail.gmail.com
This commit is contained in:
parent
d40abd5fcf
commit
ff43b3e88e
@ -4638,7 +4638,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
|
|||||||
</row>
|
</row>
|
||||||
<row>
|
<row>
|
||||||
<entry><type>bool</type></entry>
|
<entry><type>bool</type></entry>
|
||||||
<entry><type>char</type></entry>
|
<entry><type>unsigned char</type></entry>
|
||||||
</row>
|
</row>
|
||||||
|
|
||||||
</tbody>
|
</tbody>
|
||||||
|
@ -9,10 +9,10 @@
|
|||||||
|
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Typedefs used in PostgreSQL.
|
* Typedefs used in PostgreSQL probes.
|
||||||
*
|
*
|
||||||
* NOTE: Do not use system-provided typedefs (e.g. uintptr_t, uint32_t, etc)
|
* NOTE: Do not use system-provided typedefs (e.g. uintptr_t, uint32_t, etc)
|
||||||
* in probe definitions, as they cause compilation errors on macOS 10.5.
|
* in probe definitions, as they cause compilation errors on macOS.
|
||||||
*/
|
*/
|
||||||
#define LocalTransactionId unsigned int
|
#define LocalTransactionId unsigned int
|
||||||
#define LWLockMode int
|
#define LWLockMode int
|
||||||
@ -20,7 +20,7 @@
|
|||||||
#define BlockNumber unsigned int
|
#define BlockNumber unsigned int
|
||||||
#define Oid unsigned int
|
#define Oid unsigned int
|
||||||
#define ForkNumber int
|
#define ForkNumber int
|
||||||
#define bool char
|
#define bool unsigned char
|
||||||
|
|
||||||
provider postgresql {
|
provider postgresql {
|
||||||
|
|
||||||
|
Loading…
x
Reference in New Issue
Block a user