From feb15361b34a1bbbc586ee3dc0ad970f6434aad3 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Wed, 12 Aug 2026 09:45:03 +0900 Subject: [PATCH] Fix unlink() error report in KeepFileRestoredFromArchive() KeepFileRestoredFromArchive() has been using an incorrect WAL segment name in the error report for an unlink() failure. Even without 1200dfd60c36, this was of consequence only on WIN32, where we would miss to report a segment name suffixed by ".deleted%u". Oversight in 60df192aea0e, for what looks like a copy-pasto to me. Reported-by: Fujii Masao Discussion: https://postgr.es/m/CAHGQGwHSbJnUmWCuF-QNUsGYF=iSSuzLRx1z_dLfYFwfbTu4Cw@mail.gmail.com --- src/backend/access/transam/xlogarchive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/access/transam/xlogarchive.c b/src/backend/access/transam/xlogarchive.c index 16940927af0..0d9ffc99726 100644 --- a/src/backend/access/transam/xlogarchive.c +++ b/src/backend/access/transam/xlogarchive.c @@ -398,7 +398,7 @@ KeepFileRestoredFromArchive(const char *path, const char *xlogfname) ereport(FATAL, (errcode_for_file_access(), errmsg("could not remove file \"%s\": %m", - xlogfpath))); + oldpath))); #endif reload = true; }