From fe904ac20bd042edf05cc450541cdcd811d4137d Mon Sep 17 00:00:00 2001 From: Bruce Momjian Date: Thu, 12 Nov 2020 14:33:28 -0500 Subject: [PATCH] doc: wire protocol data type for history file content is bytea Document that though the history file content is marked as bytea, it is the same a text, and neither is btyea-escaped or encoding converted. Reported-by: Brar Piening Discussion: https://postgr.es/m/6a1b9cd9-17e3-df67-be55-86102af6bdf5@gmx.de Backpatch-through: 13 - 9.5 (not master) --- doc/src/sgml/protocol.sgml | 5 ++++- src/backend/replication/walsender.c | 4 ++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml index 3177abcd918..67a00493606 100644 --- a/doc/src/sgml/protocol.sgml +++ b/doc/src/sgml/protocol.sgml @@ -1623,7 +1623,10 @@ The commands accepted in walsender mode are: Requests the server to send over the timeline history file for timeline tli. Server replies with a - result set of a single row, containing two fields: + result set of a single row, containing two fields. While the + fields are labeled as text and bytea, + they effectively return raw bytes, with no escaping or encoding + conversion: diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index 907fdad7752..0e3b8d3694f 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -463,6 +463,10 @@ SendTimeLineHistory(TimeLineHistoryCmd *cmd) pq_sendstring(&buf, "content"); /* col name */ pq_sendint(&buf, 0, 4); /* table oid */ pq_sendint(&buf, 0, 2); /* attnum */ + /* + * While this is labeled as BYTEAOID, it is the same output format + * as TEXTOID above. + */ pq_sendint(&buf, BYTEAOID, 4); /* type oid */ pq_sendint(&buf, -1, 2); /* typlen */ pq_sendint(&buf, 0, 4); /* typmod */