database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-02 09:02:37 +03:00
Code Activity

Fix minor memory leaks in pg_dump.

Browse Source 
Coverity reported the two oversights in getPublicationTables.
Valgrind found the one in determineNotNullFlags.

The mistakes in getPublicationTables seem too minor to be worth
back-patching.  determineNotNullFlags could be run enough times
to matter, but that code is new in v18.  So, no back-patch.
This commit is contained in:
Tom Lane
2025-02-12 15:46:31 -05:00
parent c45963c5d5
commit fcd77a6873
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/bin/pg_dump/pg_dump.c
View File

@ -4682,6 +4682,8 @@ getPublicationTables(Archive *fout, TableInfo tblinfo[], int numTables)
appendPQExpBufferStr(attribs, fmtId(attnames[k])); appendPQExpBufferStr(attribs, fmtId(attnames[k]));
} }
pubrinfo[j].pubrattrs = attribs->data; pubrinfo[j].pubrattrs = attribs->data;
free(attribs); /* but not attribs->data */
free(attnames);
} }
else else
pubrinfo[j].pubrattrs = NULL; pubrinfo[j].pubrattrs = NULL;
@ -9424,6 +9426,7 @@ determineNotNullFlags(Archive *fout, PGresult *res, int r,
tbinfo->notnull_constrs[j] = tbinfo->notnull_constrs[j] =
pstrdup(PQgetvalue(res, r, i_notnull_name)); pstrdup(PQgetvalue(res, r, i_notnull_name));
} }
free(default_name);
} }
} }
} }