database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-17 06:41:09 +03:00
Code Activity

Ignore dropped columns during apply of update/delete.

Browse Source 
We fail to apply updates and deletes when the REPLICA IDENTITY FULL is
used for the table having dropped columns. We didn't use to ignore dropped
columns while doing tuple comparison among the tuples from the publisher
and subscriber during apply of updates and deletes.

Author: Onder Kalaci, Shi yu
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/CACawEhVQC9WoofunvXg12aXtbqKnEgWxoRx3+v8q32AWYsdpGg@mail.gmail.com
This commit is contained in:
Amit Kapila
2023-03-21 08:50:23 +05:30
parent 44d44aa971
commit fc63e6ba86
2 changed files with 64 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/executor/execReplication.c
View File

@ -242,6 +242,14 @@ tuples_equal(TupleTableSlot *slot1, TupleTableSlot *slot2)
Form_pg_attribute att;
TypeCacheEntry *typentry;
att = TupleDescAttr(slot1->tts_tupleDescriptor, attrnum);
/*
* Ignore dropped columns as the publisher doesn't send those
*/
if (att->attisdropped)
continue;
/*
* If one value is NULL and other is not, then they are certainly not
* equal
@ -255,8 +263,6 @@ tuples_equal(TupleTableSlot *slot1, TupleTableSlot *slot2)
if (slot1->tts_isnull[attrnum] || slot2->tts_isnull[attrnum])
continue;
att = TupleDescAttr(slot1->tts_tupleDescriptor, attrnum);
typentry = lookup_type_cache(att->atttypid, TYPECACHE_EQ_OPR_FINFO);
if (!OidIsValid(typentry->eq_opr_finfo.fn_oid))
ereport(ERROR,