mirror of
https://github.com/postgres/postgres.git
synced 2025-07-30 11:03:19 +03:00
Fix assorted compiler warnings seen in the buildfarm.
Failure to use DatumGetFoo/FooGetDatum macros correctly, or at all, causes some warnings about sign conversion. This is just cosmetic at the moment but in principle it's a type violation, so clean up the instances I could find. autoprewarm.c and sharedfileset.c contained code that unportably assumed that pid_t is the same size as int. We've variously dealt with this by casting pid_t to int or to unsigned long for printing purposes; I went with the latter. Fix uninitialized-variable warning in RestoreGUCState. This is a live bug in some sense, but of no great significance given that nobody is very likely to care what "line number" is associated with a GUC that hasn't got a source file recorded.
This commit is contained in:
@ -214,9 +214,9 @@ SharedFileSetPath(char *path, SharedFileSet *fileset, Oid tablespace)
|
||||
char tempdirpath[MAXPGPATH];
|
||||
|
||||
TempTablespacePath(tempdirpath, tablespace);
|
||||
snprintf(path, MAXPGPATH, "%s/%s%d.%u.sharedfileset",
|
||||
snprintf(path, MAXPGPATH, "%s/%s%lu.%u.sharedfileset",
|
||||
tempdirpath, PG_TEMP_FILE_PREFIX,
|
||||
fileset->creator_pid, fileset->number);
|
||||
(unsigned long) fileset->creator_pid, fileset->number);
|
||||
}
|
||||
|
||||
/*
|
||||
|
Reference in New Issue
Block a user