database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

pg_combinebackup: Fix incorrect code documentation

Browse Source 
The code comment for parse_oid accidentally used the wrong parameter
when referring to the location of the last backup. Also, while there,
improve sentence wording by removing a superfluous word.

Backpatch to v17 where pg_combinebackup was addedd

Author: Amul Sul <sulamul@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Discussion: https://postgr.es/m/CAAJ_b95ecWgzcS4K3Dx0E_Yp-SLwK5JBasFgioKMSjhQLw9xvg@mail.gmail.com
Backpatch-through: 17
This commit is contained in:
Daniel Gustafsson
2025-04-15 15:27:08 +02:00
parent 8c153fcfa0
commit fb9ec9cf79
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/bin/pg_combinebackup/pg_combinebackup.c
View File

@@ -804,7 +804,7 @@ parse_oid(char *s, Oid *result)
* Copy files from the input directory to the output directory, reconstructing * Copy files from the input directory to the output directory, reconstructing
* full files from incremental files as required. * full files from incremental files as required.
* *
* If processing is a user-defined tablespace, the tsoid should be the OID * If processing a user-defined tablespace, the tsoid should be the OID
* of that tablespace and input_directory and output_directory should be the * of that tablespace and input_directory and output_directory should be the
* toplevel input and output directories for that tablespace. Otherwise, * toplevel input and output directories for that tablespace. Otherwise,
* tsoid should be InvalidOid and input_directory and output_directory should * tsoid should be InvalidOid and input_directory and output_directory should
@@ -816,7 +816,7 @@ parse_oid(char *s, Oid *result)
* *
* n_prior_backups is the number of prior backups that we have available. * n_prior_backups is the number of prior backups that we have available.
* This doesn't count the very last backup, which is referenced by * This doesn't count the very last backup, which is referenced by
* output_directory, just the older ones. prior_backup_dirs is an array of * input_directory, just the older ones. prior_backup_dirs is an array of
* the locations of those previous backups. * the locations of those previous backups.
*/ */
static void static void