From f9f4b43b8dc0174797f939af986d8c9bb52269eb Mon Sep 17 00:00:00 2001 From: Jeff Davis Date: Thu, 6 Mar 2025 00:11:12 -0800 Subject: [PATCH] Address stats export review comments. Per discussion, did not use Jian He's patch exactly. Reported-by: jian he Reviewed-by: Corey Huinker Discussion: https://postgr.es/m/CACJufxFVq=tq9u1zrHWYSbMi1T07gS9Ff0LJScMco4HZmtZ1xw@mail.gmail.com Discussion: https://postgr.es/m/CADkLM=f1n2_Vomq0gKab7xdxDHmJGgn=DE48P8fzQOp3Mrs1Qg@mail.gmail.com --- src/bin/pg_dump/pg_backup_archiver.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/bin/pg_dump/pg_backup_archiver.c b/src/bin/pg_dump/pg_backup_archiver.c index 632077113a4..7480e122b61 100644 --- a/src/bin/pg_dump/pg_backup_archiver.c +++ b/src/bin/pg_dump/pg_backup_archiver.c @@ -2936,8 +2936,8 @@ _tocEntryRequired(TocEntry *te, teSection curSection, ArchiveHandle *AH) { if (!ropt->dumpStatistics) return 0; - else - res = REQ_STATS; + + res = REQ_STATS; } /* @@ -2984,10 +2984,6 @@ _tocEntryRequired(TocEntry *te, teSection curSection, ArchiveHandle *AH) if (ropt->no_subscriptions && strcmp(te->desc, "SUBSCRIPTION") == 0) return 0; - /* If it's statistics and we don't want statistics, maybe ignore it */ - if (!ropt->dumpStatistics && strcmp(te->desc, "STATISTICS DATA") == 0) - return 0; - /* Ignore it if section is not to be dumped/restored */ switch (curSection) {