database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-11 20:28:21 +03:00
Code Activity

Fix variable confusion in BufferSync().

Browse Source 
As noted by Heikki Linnakangas, the previous coding confused the "flags"
variable with the "mask" variable.  The affect of this appears to be that
unlogged buffers would get written out at every checkpoint rather than
only at shutdown time.  Although that's arguably an acceptable failure
mode, I'm back-patching this change, since it seems like a poor idea to
rely on this happening to work.
This commit is contained in:
Robert Haas
2012-01-06 08:32:32 -05:00
parent d1d836f92c
commit f9f0484504
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/storage/buffer/bufmgr.c
View File

@ -1184,7 +1184,7 @@ BufferSync(int flags)
* buffers. But at shutdown time, we write all dirty buffers. * buffers. But at shutdown time, we write all dirty buffers.
*/ */
if (!(flags & CHECKPOINT_IS_SHUTDOWN)) if (!(flags & CHECKPOINT_IS_SHUTDOWN))
flags |= BM_PERMANENT; mask |= BM_PERMANENT;
/* /*
* Loop over all buffers, and mark the ones that need to be written with * Loop over all buffers, and mark the ones that need to be written with