mirror of
https://github.com/postgres/postgres.git
synced 2025-12-21 05:21:08 +03:00
Replace pgwin32_is_junction() with lstat().
Now that lstat() reports junction points with S_IFLNK/S_ISLINK(), and unlink() can unlink them, there is no need for conditional code for Windows in a few places. That was expressed by testing for WIN32 or S_ISLNK, which we can now constant-fold. The coding around pgwin32_is_junction() was a bit suspect anyway, as we never checked for errors, and we also know that errors can be spuriously reported because of transient sharing violations on this OS. The lstat()-based code has handling for that. This also reverts4fc6b6eeon master only. That was done because lstat() didn't previously work for symlinks (junction points), but now it does. Tested-by: Andrew Dunstan <andrew@dunslane.net> Discussion: https://postgr.es/m/CA%2BhUKGLfOOeyZpm5ByVcAt7x5Pn-%3DxGRNCvgiUPVVzjFLtnY0w%40mail.gmail.com (cherry picked from commit5fc88c5d53) Author: Thomas Munro <tmunro@postgresql.org> Author: Alexandra Wang <alexandra.wang.oss@gmail.com>
This commit is contained in:
committed by
Andrew Dunstan
parent
f2a4a137bb
commit
f95ad555de
@@ -288,7 +288,6 @@ extern int pgunlink(const char *path);
|
||||
#if defined(WIN32) && !defined(__CYGWIN__)
|
||||
extern int pgsymlink(const char *oldpath, const char *newpath);
|
||||
extern int pgreadlink(const char *path, char *buf, size_t size);
|
||||
extern bool pgwin32_is_junction(const char *path);
|
||||
|
||||
#define symlink(oldpath, newpath) pgsymlink(oldpath, newpath)
|
||||
#define readlink(path, buf, size) pgreadlink(path, buf, size)
|
||||
|
||||
Reference in New Issue
Block a user