database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-09-08 00:47:37 +03:00
Code Activity

When dumping CREATE INDEX, must show opclass name if the opclass isn't

Browse Source 
in the schema search path.  Otherwise pg_dump doesn't correctly dump
scenarios where a custom opclass is created in 'public' and then used
by indexes in other schemas.
This commit is contained in:
Tom Lane
2003-10-02 22:25:08 +00:00
parent 243f11ccf1
commit f8ee74faeb
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/utils/adt/ruleutils.c
View File

@@ -3,7 +3,7 @@
* back to source text * back to source text
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.124.2.1 2003/01/08 22:54:36 momjian Exp $ * $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.124.2.2 2003/10/02 22:25:08 tgl Exp $
* *
* This software is copyrighted by Jan Wieck - Hamburg. * This software is copyrighted by Jan Wieck - Hamburg.
* *
@@ -2951,6 +2951,7 @@ get_opclass_name(Oid opclass, Oid actual_datatype,
Form_pg_opclass opcrec; Form_pg_opclass opcrec;
char *opcname; char *opcname;
char *nspname; char *nspname;
bool isvisible;
/* Domains use their base type's default opclass */ /* Domains use their base type's default opclass */
if (OidIsValid(actual_datatype)) if (OidIsValid(actual_datatype))
@@ -2962,11 +2963,16 @@ get_opclass_name(Oid opclass, Oid actual_datatype,
if (!HeapTupleIsValid(ht_opc)) if (!HeapTupleIsValid(ht_opc))
elog(ERROR, "cache lookup failed for opclass %u", opclass); elog(ERROR, "cache lookup failed for opclass %u", opclass);
opcrec = (Form_pg_opclass) GETSTRUCT(ht_opc); opcrec = (Form_pg_opclass) GETSTRUCT(ht_opc);
if (actual_datatype != opcrec->opcintype || !opcrec->opcdefault)
/* Must force use of opclass name if not in search path */
isvisible = OpclassIsVisible(opclass);
if (actual_datatype != opcrec->opcintype || !opcrec->opcdefault ||
!isvisible)
{ {
/* Okay, we need the opclass name. Do we need to qualify it? */ /* Okay, we need the opclass name. Do we need to qualify it? */
opcname = NameStr(opcrec->opcname); opcname = NameStr(opcrec->opcname);
if (OpclassIsVisible(opclass)) if (isvisible)
appendStringInfo(buf, " %s", quote_identifier(opcname)); appendStringInfo(buf, " %s", quote_identifier(opcname));
else else
{ {