database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-05 07:21:24 +03:00
Code Activity

Typo and doc fixups for memory context reporting

Browse Source 
This fixes comment and docs typos as well as a small documentation
change to make it clearer.  Found via post-commit review.

Author: Rahila Syed <rahilasyed90@gmail.com>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/CAH2L28vt16C9xTuK+K7QZvtA3kCNWXOEiT=gEekUw3Xxp9LVQw@mail.gmail.com
This commit is contained in:
Daniel Gustafsson
2025-04-30 11:10:27 +02:00
parent d2a1ed1727
commit f8c115a6cb
2 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
doc/src/sgml/func.sgml
View File

@ -28780,8 +28780,7 @@ acl | {postgres=arwdDxtm/postgres,foo=r/postgres}
indicate the number aggregated child contexts. When indicate the number aggregated child contexts. When
<parameter>summary</parameter> is <literal>false</literal>, <parameter>summary</parameter> is <literal>false</literal>,
<literal>the num_agg_contexts</literal> value is <literal>1</literal>, <literal>the num_agg_contexts</literal> value is <literal>1</literal>,
indicating that individual statistics are being displayed. The levels indicating that individual statistics are being displayed.
are limited to the first 100 contexts.
</para> </para>
<para> <para>
Busy processes can delay reporting memory context statistics, Busy processes can delay reporting memory context statistics,
@ -28796,7 +28795,7 @@ acl | {postgres=arwdDxtm/postgres,foo=r/postgres}
statistics are aggregated and a cumulative total is displayed. The statistics are aggregated and a cumulative total is displayed. The
<literal>num_agg_contexts</literal> column indicates the number of <literal>num_agg_contexts</literal> column indicates the number of
contexts aggregated in the displayed statistics. When contexts aggregated in the displayed statistics. When
<literal>num_agg_contexts</literal> is <literal>1</literal> is means <literal>num_agg_contexts</literal> is <literal>1</literal> it means
that the context statistics are displayed separately. that the context statistics are displayed separately.
</para></entry> </para></entry>
</row> </row>

14
src/backend/utils/mmgr/mcxt.c
View File

@ -1493,8 +1493,8 @@ ProcessGetMemoryContextInterrupt(void)
/* /*
* Create a DSA and send handle to the client process after storing the * Create a DSA and send handle to the client process after storing the
* context statistics. If number of contexts exceed a predefined * context statistics. If number of contexts exceed a predefined limit
* limit(8MB), a cumulative total is stored for such contexts. * (1MB), a cumulative total is stored for such contexts.
*/ */
if (memCxtArea->memstats_dsa_handle == DSA_HANDLE_INVALID) if (memCxtArea->memstats_dsa_handle == DSA_HANDLE_INVALID)
{ {
@ -1512,8 +1512,10 @@ ProcessGetMemoryContextInterrupt(void)
/* /*
* Pin the DSA area, this is to make sure the area remains attachable * Pin the DSA area, this is to make sure the area remains attachable
* even if current backend exits. This is done so that the statistics * even if the backend that created it exits. This is done so that the
* are published even if the process exits while a client is waiting. * statistics are published even if the process exits while a client
* is waiting. Also, other processes that publish statistics will use
* the same area.
*/ */
dsa_pin(MemoryStatsDsaArea); dsa_pin(MemoryStatsDsaArea);
@ -1580,7 +1582,7 @@ ProcessGetMemoryContextInterrupt(void)
cxt_id = cxt_id + 1; cxt_id = cxt_id + 1;
/* /*
* Copy statistics for each of TopMemoryContexts children. This * Copy statistics for each of TopMemoryContexts children. This
* includes statistics of at most 100 children per node, with each * includes statistics of at most 100 children per node, with each
* child node limited to a depth of 100 in its subtree. * child node limited to a depth of 100 in its subtree.
*/ */
@ -1609,9 +1611,9 @@ ProcessGetMemoryContextInterrupt(void)
} }
memCxtState[idx].total_stats = cxt_id; memCxtState[idx].total_stats = cxt_id;
/* Notify waiting backends and return */
end_memorycontext_reporting(); end_memorycontext_reporting();
/* Notify waiting backends and return */
hash_destroy(context_id_lookup); hash_destroy(context_id_lookup);
return; return;