From f863d82b2f9801c556882ca92b519982a82133e3 Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Thu, 6 Jul 2023 21:21:37 +0200 Subject: [PATCH] pg_regress: Remove unused variable The restrictedToken handle was set but never read, so remove the variable and change to a boolean style check to match other uses of CreateRestrictedProcess(). Reviewed-by: Nathan Bossart Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/62A63C81-3893-4E3F-A34E-2081DF67074E@yesql.se --- src/test/regress/pg_regress.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c index 3e4fd918dd8..b68632320a7 100644 --- a/src/test/regress/pg_regress.c +++ b/src/test/regress/pg_regress.c @@ -1226,7 +1226,6 @@ spawn_process(const char *cmdline) #else PROCESS_INFORMATION pi; char *cmdline2; - HANDLE restrictedToken; const char *comspec; /* Find CMD.EXE location using COMSPEC, if it's set */ @@ -1237,8 +1236,7 @@ spawn_process(const char *cmdline) memset(&pi, 0, sizeof(pi)); cmdline2 = psprintf("\"%s\" /c \"%s\"", comspec, cmdline); - if ((restrictedToken = - CreateRestrictedProcess(cmdline2, &pi)) == 0) + if (!CreateRestrictedProcess(cmdline2, &pi)) exit(2); CloseHandle(pi.hThread);