database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

plperl: Fix memory leak in hek2cstr

Browse Source 
Backpatch all the way back to 9.1, where it was introduced by commit
50d89d42.

Reported by Sergey Burladyan in #9223
Author: Alex Hunsaker
This commit is contained in:
Alvaro Herrera
2014-03-16 23:22:22 -03:00
parent 8976360ea6
commit f84997c7e6
1 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/pl/plperl/plperl.c
View File

@@ -303,6 +303,16 @@ static char *setlocale_perl(int category, char *locale);
static char * static char *
hek2cstr(HE *he) hek2cstr(HE *he)
{ {
char *ret;
SV *sv;
/*
* HeSVKEY_force will return a temporary mortal SV*, so we need to make
* sure to free it with ENTER/SAVE/FREE/LEAVE
*/
ENTER;
SAVETMPS;
/*------------------------- /*-------------------------
* Unfortunately, while HeUTF8 is true for most things > 256, for values * Unfortunately, while HeUTF8 is true for most things > 256, for values
* 128..255 it's not, but perl will treat them as unicode code points if * 128..255 it's not, but perl will treat them as unicode code points if
@@ -327,11 +337,17 @@ hek2cstr(HE *he)
* right thing * right thing
*------------------------- *-------------------------
*/ */
SV *sv = HeSVKEY_force(he);
sv = HeSVKEY_force(he);
if (HeUTF8(he)) if (HeUTF8(he))
SvUTF8_on(sv); SvUTF8_on(sv);
return sv2cstr(sv); ret = sv2cstr(sv);
/* free sv */
FREETMPS;
LEAVE;
return ret;
} }
/* /*